This repository was archived by the owner on Jan 16, 2025. It is now read-only.
Fix babel build error, convert Poll class into a function#1594
Draft
JSReds wants to merge 1 commit into
Draft
Conversation
thgreasi
reviewed
May 25, 2022
|
|
||
| export const createPoll = ( | ||
| fn: (poll: Poll) => Promise<any>, | ||
| fn: () => Promise<any>, |
Contributor
There was a problem hiding this comment.
I think we do use this in the UI to check whether the poll is cancelled.
Or maybe we only do that for useRequest 🤔 ?
Change-type: patch Signed-off-by: Andrea Rosci <andrear@balena.io>
f7d6ec6 to
3fad43c
Compare
Contributor
Author
|
need discussion, the fix was released with #1595 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-type: patch
Signed-off-by: Andrea Rosci andrear@balena.io
This PR should resolve a babel build error:
Contributor checklist
npm run generate-snapshotsReviewer Guidelines