Skip to content

Conversation

@rdulmina
Copy link
Contributor

Purpose

Typedesc class names are different for subsequent compilations. Because of this, it gives NoClassDefFoundError intermittently when compiling https://github.com/isuruh15/solutions-healthcare-demos/tree/bal-issue/use-cases/patient-admit-hl7v2/hl7v2-fhir-integration

Fixes #44420

@rdulmina rdulmina changed the title Typedesc class names are different for subsequent compilations [Master] Typedesc class names are different for subsequent compilations Nov 25, 2025
@keizer619 keizer619 requested a review from Copilot November 26, 2025 05:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where typedesc class names were inconsistent across subsequent compilations, causing intermittent NoClassDefFoundError exceptions. The root cause was that counter variables used to generate unique names for desugared constructs were not being reset between compilations.

Key changes:

  • Added counter resets in clearGlobalVariables() method to ensure consistent naming across compilations
  • Removed unused constant ERROR_REASON_NULL_REFERENCE_ERROR and method resetSkipFailStmtRewrite()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.03%. Comparing base (ec4fd02) to head (8a4fb2d).
⚠️ Report is 66 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #44421   +/-   ##
=========================================
  Coverage     75.03%   75.03%           
- Complexity    58624    58626    +2     
=========================================
  Files          3600     3600           
  Lines        226760   226768    +8     
  Branches      29518    29518           
=========================================
+ Hits         170145   170152    +7     
- Misses        47135    47136    +1     
  Partials       9480     9480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rdulmina rdulmina merged commit c599a10 into ballerina-platform:master Nov 28, 2025
58 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Typedesc class names are different for subsequent compilations

2 participants