-
Notifications
You must be signed in to change notification settings - Fork 82
feat: Add state root calculation time from latest flashblock state to metering RPC #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
niran
wants to merge
25
commits into
main
Choose a base branch
from
meter-state-root
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
fda04a5
Include state root calculation time in metering
niran fe163b4
Update tips-core and expose state root time in RPC response
niran 305a2ce
Add tests for state root time metrics
niran ad9586d
Simplify state root calculation by removing unnecessary ExecutionOutc…
niran d741e03
Use pending flashblocks state for bundle metering
niran 8929514
Cache flashblock trie nodes to optimize bundle metering
niran 2c8699f
linter fixes
niran afe211a
Rename total_execution_time to total_time for clarity
niran 76c6c0e
Refactor flashblock trie data handling to reduce code duplication
niran 62bd1c3
Add chain-state metering tests and flashblock harness support
niran 8749989
Fix chain-state metering tests with L1 deposit
niran 5aacb8a
Restore beacon root for successful metering tests
niran e55c43a
Have storage persistence test meter the next block
niran a41a001
Rename metering tests for clarity
niran 3572284
Drop redundant beacon-root RPC test
niran eb37396
Document why flashblock trie caching isolates bundle I/O
niran 82b03cb
Move build_single_flashblock from metering to test-utils
niran 4211c10
tweak comments
niran 5b05bb2
Update tips-core and fix metering harness/tests
niran 9d07837
Silence the global executor errors
niran d8c7184
Add TODO for state_root_time
niran 9752d0a
Add metrics for bundle state clone cost
niran 1942db8
Add database layering tests to flashblocks-rpc
niran 5fbc033
Add tests for flashblock state visibility
niran 4d324f5
just fix
niran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any intuition for how expensive this clone can get? Slightly concerned about introducing a perf regression here. A not too older version here had a significant perf regression because of some extremely large clones that started happening. Im unsure how fast bundlestate can grow.
This may be worth testing on mainnet dev node before merging to main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added metrics for this in 9752d0a.