fix: prevent surrogate pairs from being split by the selected range#1226
Open
Thomaash wants to merge 1 commit intobasecamp:mainfrom
Open
fix: prevent surrogate pairs from being split by the selected range#1226Thomaash wants to merge 1 commit intobasecamp:mainfrom
Thomaash wants to merge 1 commit intobasecamp:mainfrom
Conversation
Contributor
Author
|
Hi @jorgemanrubia, could I ask for a code review? |
Contributor
Author
|
Hi @jorgemanrubia or @flavorjones, is there any chance for this to be reviewed and merged/rejected? |
This is already handled in functions like `expandSelectionInDirection` which won't select a half of emoji etc. but always the whole surrogate pair. The solution here is the same, if the cursor is placed in the middle of a surrogate pair, it will be moved to the end of the pair. Similarly a selection will either select both or neither.
Member
|
I've rebased this onto current @Thomaash can you say a bit more about how this problem occurs in an application -- how is the cursor ending up in the middle of a multi-byte code point? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is already handled in functions like
expandSelectionInDirectionwhich won't select a half of emoji etc. but always the whole surrogate pair. The solution here is the same, if the cursor is placed in the middle of a surrogate pair, it will be moved to the end of the pair. Similarly a selection will either select both or neither.