feature/process pool executor support#1328
Closed
antlobach wants to merge 2 commits into
Closed
Conversation
Implemented ProcessPoolExecutor support with cloudpickle-based serialization so Basilisp futures can run in subprocesses, including closures and dynamic bindings. Added robust handling for low FD limits and lifecycle cleanup to avoid 'too many open files' errors, and ensured pools created via binding shut down automatically to prevent resource leaks. Also added a clean-cache Makefile target and expanded .gitignore for editor/temp files.
Member
|
@antlobach thank you for your interest in the project and for the submission. Unfortunately, we have made the decision at this time to not accept AI generated contributions. Setting aside the AI generation aspect, while I do think this is an interesting concept I'm not sure I want to bring in this additional dependency right now. Perhaps it can be spun out into a separate dependency? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the help of Claude code and Codex, I've managed to implemented support for ProcessPoolExecutor using cloudpickle. It passes all tests locally on Python 3.14, but I wasn’t able to run tests on other Python versions.
I asked Codex to write a detailed overview of the implementation, which is in dev-notes/process-pool-executor-support.md
Please feel free to reject this if it’s not a fit, but I thought it might be of interest to review.