Skip to content

[DNM] WS-2116 - Next batch of new nav rollout#13872

Merged
amoore108 merged 15 commits intolatestfrom
WS-2116-new-nav-8th-rollout
Apr 8, 2026
Merged

[DNM] WS-2116 - Next batch of new nav rollout#13872
amoore108 merged 15 commits intolatestfrom
WS-2116-new-nav-8th-rollout

Conversation

@amoore108
Copy link
Copy Markdown
Contributor

@amoore108 amoore108 commented Apr 2, 2026

Resolves JIRA: https://bbc.atlassian.net/browse/WS-2116

Summary

Rolls out new nav to Afaan Oromoo, Amharic, Afrique, Gujarati, Hausa, Igbo, Gahuza, Pidgin, Somali, Swahili, Tigrinya and Yoruba services

Code changes

  • Adds services to SERVICES_WITH_NEW_NAV list
  • Updates SVGs for each of the services
  • Small update to the isGlobalLanguageHomepage function in the BBC blocks banner to handle undefined inputPathname values

Testing

  1. List the steps required to test this PR.

Useful Links

@amoore108 amoore108 self-assigned this Apr 2, 2026
@amoore108 amoore108 marked this pull request as ready for review April 2, 2026 11:34
Copilot AI review requested due to automatic review settings April 2, 2026 11:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Rolls out the “new navigation” experience to an additional set of World Service language services by enabling the new-nav flag for those services and updating their corresponding Chameleon brand SVGs to match the new header/navigation requirements.

Changes:

  • Expanded SERVICES_WITH_NEW_NAV to include Afaan Oromoo, Amharic, Afrique, Gahuza, Hausa, Igbo, Pidgin, Somali, Swahili, Tigrinya, and Yoruba.
  • Updated Chameleon logo SVG definitions for the newly enabled services (including introducing explicit viewbox cropping values).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/app/components/Navigation/config.ts Enables new navigation for the next batch of services by adding them to the rollout allowlist.
src/app/components/ThemeProvider/chameleonLogos/afaanoromoo.tsx Updates Afaan Oromoo Chameleon logo SVG and sets an explicit viewbox for cropping.
src/app/components/ThemeProvider/chameleonLogos/amharic.tsx Updates Amharic Chameleon logo SVG and sets an explicit viewbox for cropping.
src/app/components/ThemeProvider/chameleonLogos/afrique.tsx Updates Afrique Chameleon logo SVG and sets an explicit viewbox for cropping.
src/app/components/ThemeProvider/chameleonLogos/gahuza.tsx Updates Gahuza Chameleon logo SVG and sets an explicit viewbox for cropping.
src/app/components/ThemeProvider/chameleonLogos/hausa.tsx Updates Hausa Chameleon logo SVG and sets an explicit viewbox for cropping.
src/app/components/ThemeProvider/chameleonLogos/igbo.tsx Updates Igbo Chameleon logo SVG and sets an explicit viewbox for cropping.
src/app/components/ThemeProvider/chameleonLogos/pidgin.tsx Updates Pidgin Chameleon logo SVG and sets an explicit viewbox for cropping.
src/app/components/ThemeProvider/chameleonLogos/somali.tsx Updates Somali Chameleon logo SVG and sets an explicit viewbox for cropping.
src/app/components/ThemeProvider/chameleonLogos/swahili.tsx Updates Swahili Chameleon logo SVG and sets an explicit viewbox for cropping.
src/app/components/ThemeProvider/chameleonLogos/tigrinya.tsx Updates Tigrinya Chameleon logo SVG and sets an explicit viewbox for cropping.
src/app/components/ThemeProvider/chameleonLogos/yoruba.tsx Updates Yoruba Chameleon logo SVG and sets an explicit viewbox for cropping.

@amoore108 amoore108 changed the title WS-2116 - Next batch of new nav rollout [DNM] WS-2116 - Next batch of new nav rollout Apr 2, 2026
Comment on lines -4 to -5
width: 2246,
height: 425,
Copy link
Copy Markdown
Contributor

@Nabeel1276 Nabeel1276 Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see these have been redefined in the viewbox object, but the values are different. Why are they different and are these values for the same thing or is viewbox separate? Where do the new SVG values come from?

Copy link
Copy Markdown
Contributor Author

@amoore108 amoore108 Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The width changes because we've removed the <path /> element that made the BBC blocks.

The explicit width and height properties ended up in the viewBox attribute on the SVG anyway, so this is just a small simplification:

viewbox: viewbox || {
minX: margin,
minY: margin,
width: croppedWidth,
height: croppedHeight,
},

The values are hand crafted, just whatever was needed to make the SVG size correct and the underline on mouse hover fit properly.

@amoore108 amoore108 merged commit d195169 into latest Apr 8, 2026
13 checks passed
@amoore108 amoore108 deleted the WS-2116-new-nav-8th-rollout branch April 14, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants