[DNM] WS-2116 - Next batch of new nav rollout#13872
Conversation
There was a problem hiding this comment.
Pull request overview
Rolls out the “new navigation” experience to an additional set of World Service language services by enabling the new-nav flag for those services and updating their corresponding Chameleon brand SVGs to match the new header/navigation requirements.
Changes:
- Expanded
SERVICES_WITH_NEW_NAVto include Afaan Oromoo, Amharic, Afrique, Gahuza, Hausa, Igbo, Pidgin, Somali, Swahili, Tigrinya, and Yoruba. - Updated Chameleon logo SVG definitions for the newly enabled services (including introducing explicit
viewboxcropping values).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/components/Navigation/config.ts | Enables new navigation for the next batch of services by adding them to the rollout allowlist. |
| src/app/components/ThemeProvider/chameleonLogos/afaanoromoo.tsx | Updates Afaan Oromoo Chameleon logo SVG and sets an explicit viewbox for cropping. |
| src/app/components/ThemeProvider/chameleonLogos/amharic.tsx | Updates Amharic Chameleon logo SVG and sets an explicit viewbox for cropping. |
| src/app/components/ThemeProvider/chameleonLogos/afrique.tsx | Updates Afrique Chameleon logo SVG and sets an explicit viewbox for cropping. |
| src/app/components/ThemeProvider/chameleonLogos/gahuza.tsx | Updates Gahuza Chameleon logo SVG and sets an explicit viewbox for cropping. |
| src/app/components/ThemeProvider/chameleonLogos/hausa.tsx | Updates Hausa Chameleon logo SVG and sets an explicit viewbox for cropping. |
| src/app/components/ThemeProvider/chameleonLogos/igbo.tsx | Updates Igbo Chameleon logo SVG and sets an explicit viewbox for cropping. |
| src/app/components/ThemeProvider/chameleonLogos/pidgin.tsx | Updates Pidgin Chameleon logo SVG and sets an explicit viewbox for cropping. |
| src/app/components/ThemeProvider/chameleonLogos/somali.tsx | Updates Somali Chameleon logo SVG and sets an explicit viewbox for cropping. |
| src/app/components/ThemeProvider/chameleonLogos/swahili.tsx | Updates Swahili Chameleon logo SVG and sets an explicit viewbox for cropping. |
| src/app/components/ThemeProvider/chameleonLogos/tigrinya.tsx | Updates Tigrinya Chameleon logo SVG and sets an explicit viewbox for cropping. |
| src/app/components/ThemeProvider/chameleonLogos/yoruba.tsx | Updates Yoruba Chameleon logo SVG and sets an explicit viewbox for cropping. |
| width: 2246, | ||
| height: 425, |
There was a problem hiding this comment.
I see these have been redefined in the viewbox object, but the values are different. Why are they different and are these values for the same thing or is viewbox separate? Where do the new SVG values come from?
There was a problem hiding this comment.
The width changes because we've removed the <path /> element that made the BBC blocks.
The explicit width and height properties ended up in the viewBox attribute on the SVG anyway, so this is just a small simplification:
simorgh/src/app/components/ThemeProvider/chameleonLogos/index.tsx
Lines 22 to 27 in 37e9dcc
The values are hand crafted, just whatever was needed to make the SVG size correct and the underline on mouse hover fit properly.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2116
Summary
Rolls out new nav to Afaan Oromoo, Amharic, Afrique, Gujarati, Hausa, Igbo, Gahuza, Pidgin, Somali, Swahili, Tigrinya and Yoruba services
Code changes
SERVICES_WITH_NEW_NAVlistisGlobalLanguageHomepagefunction in the BBC blocks banner to handleundefinedinputPathnamevaluesTesting
Useful Links