Allow selecting either tags or genres in the includes, defaulting to genres

[aereaux]

Description

Genres is a filtered list based on what musicbrainz considers a genre, tags are all the user-submitted tags. [1]

1. https://musicbrainz.org/doc/MusicBrainz_API#:~:text=Since%20genres%20are,!).

To Do

• Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
• Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
• Tests. (Very much encouraged but not strictly required.)

[github-actions]

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.44%. Comparing base (f3da80e) to head (672bf0b).
⚠️ Report is 4 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5874      +/-   ##
==========================================
+ Coverage   67.39%   67.44%   +0.04%     
==========================================
  Files         136      136              
  Lines       18523    18526       +3     
  Branches     3129     3129              
==========================================
+ Hits        12484    12494      +10     
+ Misses       5375     5369       -6     
+ Partials      664      663       -1     

Files with missing lines	Coverage Δ
beetsplug/musicbrainz.py	79.11% <100.00%> (+2.00%)	⬆️

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aereaux]

Hi! Anything else I need to do for this PR?

[snejus]

Apologies - couldn't review this earlier. The build seems to be failing due to documentation formatting and typing issues - are you happy to address these?

[aereaux]

Thanks!

I fixed the typing error and one of the docs formatting, but I'm not sure what it's complaining about with the other docs file.

[snejus]

I fixed the typing error and one of the docs formatting, but I'm not sure what it's complaining about with the other docs file.

Just try running poe format-docs command and it should get fixed!

[aereaux]

I tried that but ran into this error: FileNotFoundError: [Errno 2] No such file or directory: '/home/<me>/.local/lib/beets/*.rst'.

After some experimenting I ran docstrfmt -p /dev/null docs/plugins/musicbrainz.rst, and that reformatted the entire document (not the parts that I changed), so I was wondering if I was doing something wrong.

[snejus]

dr

docstrfmt -p /dev/null docs/plugins/musicbrainz.rst

Try

docstrfmt -p pyproject.toml docs/plugins/musicbrainz.rst

[aereaux]

Sorry, for the late response, I didn't get a notification for that. I still get this error with that command: FileNotFoundError: [Errno 2] No such file or directory: '/home/user/.local/lib/beets/*.rst'

[aereaux]

OK, it was a little complicated and I'm not sure why it wasn't working but I think I got the linting to pass. Anything else I need to do for this?

[aereaux]

Hi again! Anything else I need to do for this PR?

[JOJ0]

LGTM but since @snejus requested changes initially I'd like to ask them for the final go :-)

[snejus]

Also @aereaux would you mind including genre-list field with some example values somewhere in the test release data in test/plugins/test_musicbrainz.py to make sure that this new configuration is covered?

[aereaux]

OK, I think I got the tests right. Let me know how that looks!

Thanks!

[snejus]

Nice, thanks!