Skip to content

Conversation

@semohr
Copy link
Contributor

@semohr semohr commented Sep 16, 2025

I propose we remove the deprecation warning for beets.mediafile. This warning was introduced in version 1.6.0.

While we could schedule the removal for version 3.0.0, it should be safe to remove it now since the feature has been deprecated for over three years.

ref: #4263

@semohr semohr requested review from Copilot and removed request for Copilot September 16, 2025 14:05
@semohr semohr requested a review from a team as a code owner September 16, 2025 14:05
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fully removes the long-deprecated beets.mediafile module by deleting its implementation file and cleans up the corresponding deprecation warning entry in the project changelog.

File-Level Changes

Change Details Files
Remove deprecated mediafile module
  • Deleted the beets/mediafile.py file
beets/mediafile.py
Clean up deprecation entry in changelog
  • Removed the beets.mediafile deprecation warning from docs/changelog.rst
docs/changelog.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot AI review requested due to automatic review settings September 16, 2025 14:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated beets.mediafile module that has been showing a deprecation warning since version 1.6.0. The module was a compatibility shim that imported and re-exported everything from the mediafile module.

  • Completely removes the beets/mediafile.py file
  • Updates the changelog to document the removal for packagers

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
beets/mediafile.py Complete removal of deprecated compatibility module
docs/changelog.rst Documents the removal in changelog for packagers

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.54%. Comparing base (394d78d) to head (d46365f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6016      +/-   ##
==========================================
+ Coverage   66.52%   66.54%   +0.02%     
==========================================
  Files         117      116       -1     
  Lines       18084    18077       -7     
  Branches     3061     3059       -2     
==========================================
  Hits        12030    12030              
+ Misses       5403     5396       -7     
  Partials      651      651              
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JOJ0 JOJ0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! it's time! :-) Thanks!

Copy link
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a major version increase in order to remove it.

@semohr semohr added this to the 3.0.0 milestone Sep 17, 2025
@semohr
Copy link
Contributor Author

semohr commented Sep 17, 2025

Added 3.0.0 as milestone. Might help us keep track of it.

@semohr semohr marked this pull request as draft October 11, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants