Skip to content

Accept lyrics source as a string #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2025
Merged

Accept lyrics source as a string #6149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9afe06
Accept lyrics source as a string
DogeTheBeast Nov 7, 2025
a7becf8
Improve changelog
DogeTheBeast Nov 7, 2025
60ad6dc
Fix changelog formatting
DogeTheBeast Nov 7, 2025
f77c03e
Remove unnecessary space
DogeTheBeast Nov 7, 2025
26a8e16
Remove newline character between list points
DogeTheBeast Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion beetsplug/lyrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,7 @@ class LyricsPlugin(RequestHandler, plugins.BeetsPlugin):

@cached_property
def backends(self) -> list[Backend]:
user_sources = self.config["sources"].get()
user_sources = self.config["sources"].as_str_seq()

chosen = sanitize_choices(user_sources, self.BACKEND_BY_NAME)
if "google" in chosen and not self.config["google_API_key"].get():
Expand Down
2 changes: 2 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ Bug fixes:
audio-features endpoint, the plugin logs a warning once and skips audio
features for all remaining tracks in the session, avoiding unnecessary API
calls and rate limit exhaustion.
- :doc:`plugins/lyrics`: Accepts strings for lyrics sources (previously only
accepted a list of strings). :bug:`5962`

For plugin developers:

Expand Down
Loading