Fix intermittent assert failures in lutpack functions#505
Merged
alanminko merged 2 commits intoberkeley-abc:masterfrom May 3, 2026
Merged
Fix intermittent assert failures in lutpack functions#505alanminko merged 2 commits intoberkeley-abc:masterfrom
alanminko merged 2 commits intoberkeley-abc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assert on line 200 causes intermittent failures for FPGA flows (as seen here). The assert is checking that pData doesn't hold a "small integer value" (<= 0xFFFF) which is a valid defensive check.
However, the check casts pData (8B on 64-bit) through ABC_PTRUINT_T to unsigned, which truncates the high 32 bits.
When pData is a valid pointer to data allocated at or above 4 GB boundaries, this assert is triggered because the high bits are non-zero but the lower 32 bits can be near zero.
This fix preserves the original intent and is safe on 32-bit and 64-bit platforms.