Skip to content

Running Stochastic Benchmark on Simualted Annealing results#30

Merged
bernalde merged 29 commits intobernalde:mainfrom
jvpcms:main
Nov 24, 2025
Merged

Running Stochastic Benchmark on Simualted Annealing results#30
bernalde merged 29 commits intobernalde:mainfrom
jvpcms:main

Conversation

@jvpcms
Copy link
Collaborator

@jvpcms jvpcms commented Oct 14, 2025

This runs SB with:

  • defined parameters: Sweeps and Reads
  • defined resource: Sweeps * Reads (total number of queries)
  • defined performance: Approximation ratio

I'm open this PR to keep track of progress made, but Azain and I decided to keep working on his PR. I will be adding the parts where our code differs to his PR.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jvpcms
Copy link
Collaborator Author

jvpcms commented Oct 14, 2025

@bernalde

Copy link
Owner

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes were introduced to other folders that were irrelevant to this PR. I will review the notebook separately

Copy link
Owner

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some comments still unresolved. I will review the notebook once they are sorted out.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@b0139dd). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage        ?   48.68%           
=======================================
  Files           ?       14           
  Lines           ?     2280           
  Branches        ?        0           
=======================================
  Hits            ?     1110           
  Misses          ?     1170           
  Partials        ?        0           
Flag Coverage Δ
unittests 48.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jvpcms
Copy link
Collaborator Author

jvpcms commented Nov 13, 2025

@bernalde

@AzAINN
Copy link

AzAINN commented Nov 22, 2025

The following changes were made:

  • pickled the raw dimod Sampleset Objects data into one file containing only energies
  • removed dependency on pre-bootstrapped data from the Qubonotebooks so bootstrap operates on raw pickled SA runs
  • sped up the data conversion of the raw runs into SB format
  • Included native random baseline computation for each instance that the bootstrap function can use
    (The graphs appear cleaner, i.e, the VirtualBest, TrainingStats, and TrainingResults align smoothly)

@AzAINN
Copy link

AzAINN commented Nov 22, 2025

@bernalde

@bernalde bernalde requested a review from Copilot November 22, 2025 19:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@bernalde bernalde requested a review from anurag-r20 November 22, 2025 19:27
Copy link
Owner

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please run the notebook from the head to the bottom and let's wait for @anurag-r20 's revision to merge

@jvpcms
Copy link
Collaborator Author

jvpcms commented Nov 23, 2025

@anurag-r20

Copy link
Collaborator

@anurag-r20 anurag-r20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks goof! I think there is an issue with the include_groups but I have fixed that in my PR. So once that is merged, this warning should go away when you re-run.

@bernalde bernalde merged commit b81392a into bernalde:main Nov 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants