Wip/bolus wizard bg mmol units#157
Open
sulkaharo wants to merge 3 commits intobewest:wip/bolus-wizard-bg-mmol-unitsfrom
Open
Wip/bolus wizard bg mmol units#157sulkaharo wants to merge 3 commits intobewest:wip/bolus-wizard-bg-mmol-unitsfrom
sulkaharo wants to merge 3 commits intobewest:wip/bolus-wizard-bg-mmol-unitsfrom
Conversation
Owner
|
Not sure how I feel about this. Decocare is supposed to be stupid simple, like curl, it was originally a tool to tell exactly what is going on inside the device. In the past, I've been pretty disciplined/strict about separating conversions: https://github.com/openaps/openaps/blob/master/openaps/vendors/units.py, I think we're at a point where a better openaps medtronic should be created to make a lot of this easier: an oref0 version of the medtronic vendor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now running this in production and it works. I changed this to report the values in mgdl, as it's way easier to handle the data if decocare just decodes to one set of units consistently. So LGTM with my patch.