Skip to content

Fix json unmarshal error in NewGetAllOrdersService #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
goldworm-icon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix json unmarshal error in NewGetAllOrdersService #34

goldworm-icon wants to merge 1 commit into from

Conversation

@goldworm-icon
Copy link

@goldworm-icon goldworm-icon commented Jul 4, 2024 •
edited
Loading

  • NewAllOrdersResponse.WorkingTime of an canceled order is -1, which causes json unmarshal error in NewGetAllOrdersService
  • Change the type of NewAllOrdersResponse.WorkingTime from uint64 to int64

@goldworm
Fix json unmarshal error in NewGetAllOrdersService
6953c6c 
* Change the type of NewAllOrdersResponse.WorkingTime from uint64 to int64
AlexYaroshenko
AlexYaroshenko reviewed Nov 24, 2024
View reviewed changes
Copy link

@AlexYaroshenko AlexYaroshenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AlexYaroshenko AlexYaroshenko AlexYaroshenko left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goldworm-icon @AlexYaroshenko @goldworm