Ensure consistent locale settings and optimize IR compilation#751
Open
DivikChotani wants to merge 1 commit intobinpash:mainfrom
Open
Ensure consistent locale settings and optimize IR compilation#751DivikChotani wants to merge 1 commit intobinpash:mainfrom
DivikChotani wants to merge 1 commit intobinpash:mainfrom
Conversation
- Store and compare locale environment variables before and after execution. - Checked and warned to have locale set to `LC_ALL=C.UTF-8` to guarantee consistent evaluation Signed-off-by: Divik Chotani <divik.chotani@gmail.com>
|
OS:ubuntu-20.04 |
angelhof
reviewed
Feb 26, 2025
Member
angelhof
left a comment
angelhof
left a comment
There was a problem hiding this comment.
Hmmm, looking at this PR I am not sure if this is the right approach to address this issue. We wouldn't want to warn users just if they have a different locale, but only to let them know that the evaluation results might differ. Let's keep this PR open and think about this a bit later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LC_ALL=C.UTF-8to guarantee consistent evaluationSigned-off-by: Divik Chotani divikchotani@g.ucla.edu