Issue #748: Fix arithmetic for loops in bash mode#784
Open
bhumikamittal7 wants to merge 1 commit intobinpash:mainfrom
Open
Issue #748: Fix arithmetic for loops in bash mode#784bhumikamittal7 wants to merge 1 commit intobinpash:mainfrom
bhumikamittal7 wants to merge 1 commit intobinpash:mainfrom
Conversation
Signed-off-by: bhumikamittal7 <bhumika@amuselabs.com>
angelhof
reviewed
Feb 5, 2026
Member
angelhof
left a comment
angelhof
left a comment
There was a problem hiding this comment.
I don't see the change in the actual preprocess_node_arithfor function name here. Am I missing something? Also there are a lot of changes that have nothing to do with the PR itself, could you remove them and only have:
(1) the change and fix for preprocess_node_arithfor
(2) uncommenting the tests that pass now
| export TMPDIR="${TMPDIR:-/tmp/}" | ||
| cd evaluation/tests/interface_tests | ||
| ./run_bash_tests.sh | ||
| bash run_bash_tests.sh |
Member
There was a problem hiding this comment.
Why do you need to change this or the line above in this file?
| 2 | ||
| bash: -c: line 1: syntax error: arithmetic expression required | ||
| bash: -c: line 1: syntax error: `(( i=0; "i < 3" ))' | ||
| line 1: syntax error: arithmetic expression required |
| do | ||
| echo $i | ||
| done' ; echo $?; } 2>&1 | sed 's|^.*/||' | ||
| done' ; echo $?; } 2>&1 | sed 's|^.*/||' | sed -E 's/^([^:]+: )+(line [0-9]+:)/\2/' |
| { | ||
| local shell=$1 | ||
| $shell arith-for.tests | ||
| THIS_SH=$shell $shell arith-for.tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up from #760 (remaking the same changes forking off main and closing the previous PR)