Skip to content

Fix premature ignore file move #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vagos merged 1 commit into from
Feb 28, 2026
Merged

Fix premature ignore file move #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions try
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@ try() {
## because we have already checked if it valid.
export SANDBOX_DIR

# We created "$IGNORE_FILE" up front, but now we can stash it in the sandbox.
mv "$IGNORE_FILE" "$SANDBOX_DIR"/ignore
IGNORE_FILE="$SANDBOX_DIR"/ignore

try_mount_log="$SANDBOX_DIR"/mount.log
export try_mount_log

Expand All @@ -95,6 +91,10 @@ try() {
mount -t tmpfs tmpfs "$SANDBOX_DIR"
fi

# Move ignore patterns after any tmpfs mount; mounting SANDBOX_DIR hides prior contents.
mv "$IGNORE_FILE" "$SANDBOX_DIR"/ignore
IGNORE_FILE="$SANDBOX_DIR"/ignore

mkdir -p "$SANDBOX_DIR/upperdir" "$SANDBOX_DIR/workdir" "$SANDBOX_DIR/temproot"

## Find all the directories and mounts that need to be mounted
Expand Down
Loading