Schlich/issue970#994
Closed
schlich wants to merge 4 commits intobiocore:masterfrom
Closed
Conversation
Member
|
Thanks! |
mataton
reviewed
Jul 1, 2025
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up QEMU (for ARM builds on Linux, optional) |
Collaborator
There was a problem hiding this comment.
Github now has native ARM runners, you can see our implementation in scikit-bio/2232. If you find that QEMU takes a long time during the workflow, including ubuntu-24.04-arm in the os matrix will use the new runners.
wasade
previously approved these changes
Jul 1, 2025
Collaborator
|
Closing in favor of #996 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #932 and #970
This pull request introduces several significant changes to the project's build system, dependency management, and configuration files. The most notable updates include transitioning to
pyproject.tomlfor project metadata and configuration, adding a GitHub Actions workflow for building Python wheels, and simplifyingsetup.pyby delegating metadata topyproject.toml. These changes aim to modernize the project's packaging and testing infrastructure.Build System Updates:
.github/workflows/python-package-conda.yml) to build Python wheels across multiple operating systems (Ubuntu, Windows, macOS) and upload them as artifacts. This includes support for ARM builds on Linux using QEMU.Dependency Management:
ci/conda_host_env.ymlto includegccas a dependency, ensuring compatibility with the updated build process.pyproject.toml, including build requirements (setuptools>=61.0) and runtime dependencies likenumpy,scipy, andpandas.Configuration Modernization:
setup.cfgandpytest.initopyproject.toml, consolidating settings for tools likepytestandflake8. [1] [2]Simplification of
setup.py:setup.pyto remove metadata definitions and streamline the extension-building process using a dedicatedget_extensions()function. Metadata is now managed inpyproject.toml. [1] [2]