Skip to content

Conversation

@duckaxe
Copy link
Collaborator

@duckaxe duckaxe commented Aug 21, 2025

To make it easier to work with the best(Session)Diff value in AxeOS, the info endpoint should output bestDiff and bestSessionDiff as numbers. AxeOS handles formatting (calc & sort is also much easier).

The swarm component has been adapted so that a number is used instead of a string. There are no visual changes.

This is a breaking change because the API endpoint now returns a number instead of a formatted string.

Fixes #1157

@github-actions
Copy link

github-actions bot commented Aug 21, 2025

Test Results

19 tests  ±0   19 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit cdceff5. ± Comparison against base commit 201c188.

♻️ This comment has been updated with latest results.

@WantClue WantClue added design Design Enhancements cleanup Code cleanup labels Aug 21, 2025
@WantClue WantClue added this to the 2.11.0 milestone Aug 21, 2025
@mutatrum mutatrum added the api change Changes the REST API label Aug 23, 2025
@mutatrum
Copy link
Collaborator

NACK in current state, this will break swarm if people don't upgrade all their devices in one go. Swarm needs to be able to parse the strings when they query an older version.

@0xf0xx0
Copy link
Contributor

0xf0xx0 commented Aug 23, 2025

ive done this in #667 as well uwu

@duckaxe
Copy link
Collaborator Author

duckaxe commented Aug 24, 2025

Will add legacy code. Converted to draft.

@duckaxe duckaxe marked this pull request as ready for review September 8, 2025 18:19
@duckaxe
Copy link
Collaborator Author

duckaxe commented Sep 8, 2025

Added fallback code for devices that return best (session) diff as a string. Ready for review.

Copy link
Contributor

@0xf0xx0 0xf0xx0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code ack

@duckaxe
Copy link
Collaborator Author

duckaxe commented Sep 15, 2025

@shufps maybe you can adopt this PR for Nerdaxe devices.

@WantClue WantClue self-requested a review September 20, 2025 23:04
Copy link
Collaborator

@WantClue WantClue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, please create a new issue for removing the fallback code as soon as @shufps moves over to number as well

@duckaxe
Copy link
Collaborator Author

duckaxe commented Oct 12, 2025

@WantClue Follow up ticket created.

@0xf0xx0 0xf0xx0 mentioned this pull request Oct 20, 2025
@WantClue WantClue merged commit d589be4 into bitaxeorg:master Oct 21, 2025
3 checks passed
@duckaxe duckaxe deleted the bugfix/switch-bestdiff-type-to-number branch October 22, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change Changes the REST API cleanup Code cleanup design Design Enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swarm - Best Diff. sorting incorrect

4 participants