-
Notifications
You must be signed in to change notification settings - Fork 297
Change best(Session)Diff type from string to number #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change best(Session)Diff type from string to number #1202
Conversation
|
NACK in current state, this will break swarm if people don't upgrade all their devices in one go. Swarm needs to be able to parse the strings when they query an older version. |
|
ive done this in #667 as well uwu |
|
Will add legacy code. Converted to draft. |
|
Added fallback code for devices that return best (session) diff as a string. Ready for review. |
0xf0xx0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code ack
|
@shufps maybe you can adopt this PR for Nerdaxe devices. |
main/http_server/axe-os/src/app/components/swarm/swarm.component.ts
Outdated
Show resolved
Hide resolved
main/http_server/axe-os/src/app/components/swarm/swarm.component.ts
Outdated
Show resolved
Hide resolved
WantClue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, please create a new issue for removing the fallback code as soon as @shufps moves over to number as well
|
@WantClue Follow up ticket created. |
To make it easier to work with the
best(Session)Diffvalue in AxeOS, theinfoendpoint should outputbestDiffandbestSessionDiffas numbers. AxeOS handles formatting (calc & sort is also much easier).The swarm component has been adapted so that a number is used instead of a string. There are no visual changes.
This is a breaking change because the API endpoint now returns a number instead of a formatted string.
Fixes #1157