deps(bdk_testenv)!: bump `electrsd` to `0.36.1` by oleonardolima · Pull Request #1826 · bitcoindevkit/bdk

oleonardolima · 2025-02-06T20:23:34Z

partially addresses #1949

Description

Upgrades the electrsd version from 0.28.0 to 0.36.1, migrating from old bitcoind to corepc-node and using the corepc-node_28_2 feature.

Updates the bitcoind client type for TestEnv, and its internal methods. Also, updates: bdk_bitcoind_rpc, bdk_esplora, bdk_electrum usage of bdk_testenv and TestEnv.

Notes to the reviewers

As we are upgrading to the latest electrsd, we can drop for now the pinning for home in the MSRV step.

Changelog notice

### Added
- deps(bdk_testenv): introduces `bitcoin and it's `bitcoin/rand-std` feature under `bdk_testenv/std`.
- test(bdk_bitcoind_rpc): introcuce `ClientExt` trait to use custom testing RPC client with current `bitcoincore-rpc` one.

### Changed
- deps(bdk_testenv)!: bump `electrsd` to `0.36.1`.
- deps(bdk_testenv): updates `electrsd` feature to `corepc-node_28_2`.
- test(bdk_bitcoind_rpc): update all tests to use new `ClientExt` trait when building the `Emitter`.
- test(bdk_chain): update all tests to use new `bdk_testenv`, `electrsd` and `corepc-node` APIs.
- test(bdk_esplora, bdk_electrum): update all tests to use new `bdk_testenv`, `electrsd` and `corepc-node` APIs.
- build(testenv): feature gate `mine_empty_blocks`, `reorg_empty_blocks` behind `std` feature.

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing

New Features:

I've added tests for the new feature
I've added docs for the new feature

oleonardolima · 2025-02-07T14:36:05Z

It looks like I'll need to open a PR on corepc-client to add get-block-template RPC, then I'll get back to this one :(

I'll do the same in rust-electrum-client for the tests, but I'll do it to 0.30.x instead to prevent this issue from blocking the PR there.

ValuedMammal · 2025-07-21T23:20:42Z

@oleonardolima I noticed that the getblocktemplate RPC is implemented in corepc-client.

oleonardolima · 2025-07-22T13:22:47Z

@oleonardolima I noticed that the getblocktemplate RPC is implemented in corepc-client.

Yes, it was added a few releases after I started this PR, but IIRC some other methods were missing too. I'll check that again.

ValuedMammal · 2025-07-23T21:18:44Z

Yes, it was added a few releases after I started this PR, but IIRC some other methods were missing too. I'll check that again.

Seems to be lacking good support for get_raw_mempool_verbose, at least for versions of Bitcoin Core later than 0.17.

oleonardolima · 2025-07-24T15:51:29Z

Once #1988 lands, we won't be relying on get_raw_mempool_verbose; instead, we will use get_raw_mempool. It should unblock this one.

oleonardolima · 2025-08-05T02:24:49Z

Once #1988 lands, we won't be relying on get_raw_mempool_verbose; instead, we will use get_raw_mempool. It should unblock this one.

It appears that other methods are missing in the corepc-client at electrsd 0.34. They're released on corepc-node 0.8, which will be included in the next release of electrsd. Will check if there are alternative methods for those.

oleonardolima · 2025-08-08T20:15:11Z

It appears that other methods are missing in the corepc-client at electrsd 0.34. They're released on corepc-node 0.8, which will be included in the next release of electrsd. Will check if there are alternative methods for those.

As of the latest v0.35 release, it appears that all the necessary methods are implemented in corepc-{node|client}. I went ahead and updated the bdk-testenv and bdk-electrum/esplora crates.

It requires a more significant refactor and changes for the bdk_bitcoind_rpc, as the Emitter relies on the bitcoincore-rpc ' RpcApi' trait. I can cover it all in a single PR, but would like to know what you guys think as well.

cc @ValuedMammal @LagginTimes

ValuedMammal · 2025-08-12T14:49:16Z

Replaying a comment from discord

I also noticed that updating electrsd means potentially changing the Emitter to use corepc Client because of how it relates to testenv, etc. We have to make sure switching clients doesn't negatively impact behavior, performance and stuff

ValuedMammal · 2025-11-22T04:39:01Z

We may be able to unblock this by having a way to create a new RPC client using the node credentials of a TestEnv instance but independent of the actual test client that is used by electrsd. oleonardolima#3

oleonardolima · 2025-11-22T04:44:31Z

We may be able to unblock this by having a way to create a new RPC client using the node credentials of a TestEnv instance but independent of the actual test client that is used by electrsd. oleonardolima#3

Cool, I'll take a look at your PR this morning.

crates/electrum/tests/test_electrum.rs

crates/testenv/src/lib.rs

ValuedMammal · 2026-01-22T15:20:01Z

I think you need to import bitcoin with the rand feature so it re-exports secp256k1 with it: https://docs.rs/crate/bitcoin/latest/features#rand

It's weird, because it's not a new import, but it does not fail on master though.

The old electrsd 0.28 may have been pulling in rand indirectly via bitcoincore_rpc. I was going to suggest making the std feature enable bitcoin/rand-std and feature-gating the methods that use it.

testenv/Cargo.toml

[dependencies]
bitcoin = { version = "0.32.8", default-features = false }

[features]
std = ["bdk_chain/std", "bitcoin/rand-std"]

oleonardolima · 2026-01-22T20:41:44Z

I think you need to import bitcoin with the rand feature so it re-exports secp256k1 with it: https://docs.rs/crate/bitcoin/latest/features#rand

It's weird, because it's not a new import, but it does not fail on master though.

The old electrsd 0.28 may have been pulling in rand indirectly via bitcoincore_rpc. I was going to suggest making the std feature enable bitcoin/rand-std and feature-gating the methods that use it.

testenv/Cargo.toml
[dependencies]
bitcoin = { version = "0.32.8", default-features = false }

[features]
std = ["bdk_chain/std", "bitcoin/rand-std"]

Yes, the old bitcoind was using it from the bitcoincore-rpc.

ValuedMammal

I left a few non-blocking comments and also added 2 commits in oleonardolima#4. Let me know what you think.

ValuedMammal · 2026-01-23T20:24:38Z

crates/esplora/src/async_ext.rs

        let base_url = format!("http://{}", &env.electrsd.esplora_url.clone().unwrap());
        let client = Builder::new(base_url.as_str()).build_async()?;
-        let initial_height = env.rpc_client().get_block_count()? as u32;
+        let initial_height = env.rpc_client().get_block_count()?.into_model().0 as u32;


📌 We could have a TestEnv::get_block_count that returns Result<u32>. Not a blocker for this PR though.

I'll leave this for a follow-up.

oleonardolima@2ebe82d

crates/chain/tests/test_indexed_tx_graph.rs

- upgrades the `electrsd` to latest `0.36.1`. - updates the `electrsd` features to use `corepc-node_28_2`, it's the previously named `bitcoind`. - introduce `bitcoin` as a dependency, in order to use the `bitcoind/rand-std` feature, which is now toggled by `bdk_testenv/std`. - remove the MSRV pinned `home` dependency, it's not currently required.

- introduces `ClientExt` trait to `bdk_bitcoind_rpc` common tests module. - update all `bdk_bitcoind_rpc` tests to build the `Emitter` using the `ClientExt` trait, which allows it to use the old `bitcoincore-rpc::RpcApi` with the corepc-node background.

- updates tests that relies on `bdk_testenv` to it's new `corepc-node` APIs.

Feature-gate TestEnv methods `mine_empty_blocks`, `reorg_empty_blocks` behind `std` feature, as they depend on `rand` which is only available when `std` feature is enabled.

oleonardolima · 2026-01-26T17:30:49Z

I left a few non-blocking comments and also added 2 commits in oleonardolima#4. Let me know what you think.

Thanks, those looked good, I cherry-picked the commits.

ValuedMammal

ACK 303cc70

luisschwab

ACK 303cc70

LagginTimes assigned oleonardolima Feb 7, 2025

oleonardolima force-pushed the deps/bump-electrsd-version branch from af3988d to b4d655a Compare February 9, 2025 02:57

ValuedMammal mentioned this pull request Feb 11, 2025

Update Dependencies for Compatibility and Security (Fixes #1797) #1804

Closed

8 tasks

notmandatory mentioned this pull request Mar 5, 2025

Update bdk_wallet out of date dependencies bitcoindevkit/bdk_wallet#32

Open

6 tasks

oleonardolima force-pushed the deps/bump-electrsd-version branch 4 times, most recently from ef27736 to f52f04d Compare March 22, 2025 18:46

notmandatory added this to BDK Chain Apr 23, 2025

notmandatory added the dependencies Pull requests that update a dependency file label Apr 23, 2025

notmandatory removed this from BDK Wallet Apr 23, 2025

notmandatory moved this to In Progress in BDK Chain Apr 23, 2025

notmandatory mentioned this pull request Apr 26, 2025

Update bdk out of date dependencies #1949

Open

8 tasks

oleonardolima force-pushed the deps/bump-electrsd-version branch from f52f04d to e8fc019 Compare August 5, 2025 02:23

oleonardolima force-pushed the deps/bump-electrsd-version branch 4 times, most recently from 2ab640d to 366c9d9 Compare August 8, 2025 20:11

oleonardolima mentioned this pull request Sep 29, 2025

Replace rust-bitcoincore-rpc #2049

Open

oleonardolima force-pushed the deps/bump-electrsd-version branch from 366c9d9 to a2784f5 Compare November 24, 2025 01:37

ValuedMammal self-requested a review January 21, 2026 23:44

luisschwab self-requested a review January 22, 2026 00:14

ValuedMammal reviewed Jan 22, 2026

View reviewed changes

crates/electrum/tests/test_electrum.rs Outdated Show resolved Hide resolved

crates/electrum/tests/test_electrum.rs Outdated Show resolved Hide resolved

crates/testenv/src/lib.rs Show resolved Hide resolved

oleonardolima force-pushed the deps/bump-electrsd-version branch 2 times, most recently from 530f4d5 to cfefe9f Compare January 22, 2026 20:30

oleonardolima force-pushed the deps/bump-electrsd-version branch 3 times, most recently from 4213090 to 82977cf Compare January 22, 2026 22:31

oleonardolima requested a review from ValuedMammal January 22, 2026 22:32

ValuedMammal reviewed Jan 23, 2026

View reviewed changes

oleonardolima mentioned this pull request Jan 24, 2026

Make mining more flexible in bdk_testenv #2100

Open

3 tasks

oleonardolima and others added 2 commits January 26, 2026 14:13

oleonardolima force-pushed the deps/bump-electrsd-version branch from 82977cf to ea1c6d5 Compare January 26, 2026 17:16

oleonardolima added 2 commits January 26, 2026 14:20

test(bdk_chain): update to new bdk_testenv APIs

b78a9de

- updates tests that relies on `bdk_testenv` to it's new `corepc-node` APIs.

test(bdk_esplora,bdk_electrum): update to new bdk_testenv APIs

cbad92e

oleonardolima force-pushed the deps/bump-electrsd-version branch from ea1c6d5 to d148921 Compare January 26, 2026 17:21

ValuedMammal added 2 commits January 26, 2026 14:29

build(testenv): mine_empty_blocks requires std feature

9393832

Feature-gate TestEnv methods `mine_empty_blocks`, `reorg_empty_blocks` behind `std` feature, as they depend on `rand` which is only available when `std` feature is enabled.

docs(testenv): fix rustdocs for corepc types

303cc70

oleonardolima force-pushed the deps/bump-electrsd-version branch from d148921 to 303cc70 Compare January 26, 2026 17:30

oleonardolima requested a review from ValuedMammal January 26, 2026 17:31

ValuedMammal approved these changes Jan 26, 2026

View reviewed changes

luisschwab approved these changes Jan 26, 2026

View reviewed changes

oleonardolima changed the title ~~deps(bdk_testenv): bump electrsd to 0.36.1~~ deps(bdk_testenv)!: bump electrsd to 0.36.1 Jan 26, 2026

oleonardolima merged commit b4c8c6a into bitcoindevkit:master Jan 26, 2026
17 checks passed

github-project-automation bot moved this from Needs Review to Done in BDK Chain Jan 26, 2026

oleonardolima deleted the deps/bump-electrsd-version branch January 26, 2026 20:20

Conversation

oleonardolima commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

Uh oh!

oleonardolima commented Feb 7, 2025

Uh oh!

ValuedMammal commented Jul 21, 2025

Uh oh!

oleonardolima commented Jul 22, 2025

Uh oh!

ValuedMammal commented Jul 23, 2025

Uh oh!

oleonardolima commented Jul 24, 2025

Uh oh!

oleonardolima commented Aug 5, 2025

Uh oh!

oleonardolima commented Aug 8, 2025

Uh oh!

ValuedMammal commented Aug 12, 2025

Uh oh!

ValuedMammal commented Nov 22, 2025

Uh oh!

oleonardolima commented Nov 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ValuedMammal commented Jan 22, 2026

Uh oh!

oleonardolima commented Jan 22, 2026

Uh oh!

ValuedMammal left a comment

Choose a reason for hiding this comment

Uh oh!

ValuedMammal Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

oleonardolima Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

oleonardolima Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

oleonardolima commented Jan 26, 2026

Uh oh!

ValuedMammal left a comment

Choose a reason for hiding this comment

Uh oh!

luisschwab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oleonardolima commented Feb 6, 2025 •

edited

Loading