feat(example_wallet_rpc): enhance logging with structured JSON output#1920
Closed
SharanRP wants to merge 0 commit intobitcoindevkit:masterfrom
Closed
feat(example_wallet_rpc): enhance logging with structured JSON output#1920SharanRP wants to merge 0 commit intobitcoindevkit:masterfrom
SharanRP wants to merge 0 commit intobitcoindevkit:masterfrom
Conversation
|
Hello @SharanRP, |
Author
|
@AmosOO7 Alright, I’ll make the necessary fixes and push the patch. |
Member
|
Hey @SharanRP, this PR needs to be closed and moved to the new bdk_wallet repo. Here's how:
|
Author
|
@luisschwab I will make the changes and push the PR |
Member
|
Thanks, don't forget to close this one. |
Author
|
This PR has been moved to the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhanced the
example_wallet_rpcto output information in JSON format instead of plain text. This change makes it easier to extract and process information using tools likejq, improving integration with shell scripts and external CLI tools.Key changes:
serde_jsondependency for JSON serializationNotes to the reviewers
The change is minimal and non-breaking - all the same information is being output, just in a structured JSON format. Each message includes an "event" field to easily identify the type of output, making it simpler to filter and process specific information.
The JSON format was chosen over other structured formats (like YAML) because:
Changelog notice
Added:
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing