chore(chain): deprecate CanonicalIter, and ChainOracle trait#2140
Conversation
|
I'm wondering whether it really makes sense to deprecate things that we still rely on. |
- add the deprecation warning for both `CanonicalIter` and `ChainOracle` trait, as they're planned to be removed in the future. - add `#[allow(deprecated)] throughout the code to prevent related warnings.
532946a to
9286a90
Compare
I think it's the right approach, as |
|
I don't think this is the right use of A few concrete issues:
If the goal is to communicate that these APIs are going away, a doc comment note ("This will be replaced by |
Description
As both
CanonicalIterandChainOracletrait are being removed/replaced in #2038, and they're public types, we should deprecated them in a0.23.xrelease in case any user does use them directly.Notes to the reviewers
It's simply deprecating
CanonicalIterandChainOracletrait.Changelog notice
Checklists
All Submissions: