chain 0.23.x: Fix assumed canonical tx always being unconfirmed#2150
Merged
evanlinjin merged 1 commit intobitcoindevkit:release/chain-0.23.xfrom Mar 12, 2026
Conversation
Previously there was a bug where txs added in `CanonicalizationParams::assume_canonical` were forced to always be unconfirmed (even if it's anchored in the best chain). This commit fixes this. `test_assumed_canonical_with_anchor_is_confirmed` is added to ensure expected behavior. Co-authored-by: AayushGupta56 <aayushgupt56@gmail.com>
oleonardolima
force-pushed
the
fix/assumed-canonical-check-anchor
branch
from
8d65899 to
43850b5
Compare
oleonardolima
added
the
backport
notmandatory
approved these changes
Mar 11, 2026
Member
There was a problem hiding this comment.
ACK 43850b5
I ran this through my LLM 🤖 and no problems were found. The only small issue flagged is that CanonicalReason::Assumed.descendant isn't now not used or needed. But since this is a non-api-breaking back-port it makes perfect sense to leave it as is. Also that type is removed in #2038 as part of the refactoring there.
evanlinjin
merged commit b5173b1
into
bitcoindevkit:release/chain-0.23.x
17 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2088
Depends on #2148
Backport of #2110
Changelog notice
Fixed: - Previously, assumed-canonical transactions always became unconfirmed even though the transaction may be anchored in the best chain.Checklists
All Submissions:
New Features:
Bugfixes: