example: add an example using the BIP329 crate with bdk_wallet#222
Open
Musab1258 wants to merge 8 commits intobitcoindevkit:masterfrom
Open
example: add an example using the BIP329 crate with bdk_wallet#222Musab1258 wants to merge 8 commits intobitcoindevkit:masterfrom
Musab1258 wants to merge 8 commits intobitcoindevkit:masterfrom
Conversation
Pull Request Test Coverage Report for Build 14772973936Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
notmandatory
reviewed
May 1, 2025
7be28d4 to
8f424e2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
=======================================
Coverage 86.99% 86.99%
=======================================
Files 25 25
Lines 8860 8860
=======================================
Hits 7708 7708
Misses 1152 1152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@ValuedMammal, I have resolved the merge conflicts and made the example compatible with the new bdk_wallet API changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new example file,
bip329_example.rs,that demonstrates how to manage BIP-329 wallet labels when usingbdk_wallet.This fixes issue #168 by using @praveenperera's bip329 crate rather than integrating label storage directly into the core
bdk_wallet. This follows the feedback I received from @notmandatory on the issue.The example shows how to:
bdk_wallet::Wallet..jsonl) file using thebip329crate.tempfileto avoid leaving artifacts after running.Notes to the reviewers
keys-bip39feature to generate the mnemonic and descriptors used.Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: