feat: Implement BIP-0329 wallet labels#383
Draft
Leeyah-123 wants to merge 3 commits intobitcoindevkit:masterfrom
Draft
feat: Implement BIP-0329 wallet labels#383Leeyah-123 wants to merge 3 commits intobitcoindevkit:masterfrom
Leeyah-123 wants to merge 3 commits intobitcoindevkit:masterfrom
Conversation
Leeyah-123
force-pushed
the
feat/wallet-labels-support
branch
from
90dcc91 to
df89452
Compare
Leeyah-123
changed the title
Leeyah-123
force-pushed
the
feat/wallet-labels-support
branch
2 times, most recently
from
8bd2c04 to
948b383
Compare
- Add LabelRecord::validate() for ISO8601 timestamps and rate maps - Add lenient boolean deserialization for OutputLabel.spendable field - Add ValidationError variant to LabelImportError with line numbers - Add utility functions: validate_iso8601, validate_rate_map, deserialize_option_boolsy
- Add tests for label persistence and deletion across reloads - Add import/export tests for JSONL format - Add encryption/decryption roundtrip tests - Add validation tests for timestamps, rates, and field types - Cover all label types: tx, addr, pubkey, input, output, xpub - Add error handling tests for invalid JSON and missing fields
Leeyah-123
force-pushed
the
feat/wallet-labels-support
branch
from
948b383 to
60b02c7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #383 +/- ##
==========================================
- Coverage 86.46% 86.19% -0.28%
==========================================
Files 25 26 +1
Lines 8527 9052 +525
==========================================
+ Hits 7373 7802 +429
- Misses 1154 1250 +96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements wallet label import/export support, based on the BIP 0329 specification.
Closes #168.
Changelog notice
Checklists
All Submissions:
just pbefore pushingNew Features: