deprecate descriptor and change_descriptor fields#394
deprecate descriptor and change_descriptor fields#394110CodingP wants to merge 1 commit intobitcoindevkit:masterfrom
descriptor and change_descriptor fields#394Conversation
20d4b0a to
a8430c2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #394 +/- ##
==========================================
+ Coverage 79.17% 79.77% +0.60%
==========================================
Files 24 24
Lines 5311 5266 -45
Branches 242 241 -1
==========================================
- Hits 4205 4201 -4
+ Misses 1029 988 -41
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Since these fields(`descriptor`, `change_descriptor`) will be replaced by `keyring` when we have the multi-keychain wallet.
a8430c2 to
bf9a904
Compare
network, descriptor and change_descriptor fieldsdescriptor and change_descriptor fields
|
all test have passed, clippy dont warning, approach ACK, the only thing i see need change is commit name, try use the conventional commits, see more in CONTRIBUTING, change to conventional commit to make more easy to review |
I wasn't sure what type this commit should be classified as 😅 . Should it be docs or refactor? |
|
hmmm... good question, i think docs is better than the refactor, refactor say more change code or remove, maybe (fix), (docs) our (chore) is valid, i believe change the commit name to any of this "tags" will give to PR, more relevance to a view of a maintainer |
ValuedMammal
left a comment
There was a problem hiding this comment.
I guess we can't deprecate a field until we've provided an alternative, i.e. the keyring, which is currently planned for 4.0.
|
In that case, should I close this one? |
Description
These fields are planned to be replaced by
keyringfield when we have the multi-keychain wallet so need to be deprecated following the policy in #391 .Changelog notice
network,descriptorandchange_descriptorfields ofwallet::ChangeSet.Checklists
All Submissions:
just pbefore pushing