Replace std::error::Error with core::error::Error

[luisschwab]

The Error trait is stable as of 1.81.0, so import it from core instead.

Changelog notice

# Changed

- Implement `core::error::Error` for several types and un-feature-gate `std::error::Error`.

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.77%. Comparing base (c4a3b8c) to head (fb9b0b6).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   79.06%   79.77%   +0.70%     
==========================================
  Files          24       24              
  Lines        5298     5266      -32     
  Branches      241      241              
==========================================
+ Hits         4189     4201      +12     
+ Misses       1032      988      -44     
  Partials       77       77              

Flag	Coverage Δ
rust	79.77% <ø> (+0.70%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[110CodingP]

ACK 381b425

[nymius]

cACK 381b425

[oleonardolima]

ACK fb9b0b6

I agree that the FromStr can be addressed in a follow-up.

Please add the CHANGELOG notice in the PR description, also I think this can land in the 3.0 release, wdyt @ValuedMammal ?.

[nymius]

ACK fb9b0b6

I'm not sure about adding this to the CHANGELOG. Is this noticeable enough?

[luisschwab]

For the user this is a no-op, not sure if this belongs in there. But I could be convinced otherwise.

[110CodingP]

reACK fb9b0b6

FWIW I also agree that this and #390 would be nice haves for 3.0 .

[ValuedMammal]

ACK fb9b0b6