Merged
Conversation
ArisMorgens
force-pushed
the
Aris/cflib2/LEDRingTab
branch
from
f3a4bd5 to
231c957
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Enables and modernizes the “LED Ring” UI tab, updating it to use the newer cflib2 APIs and wiring it into the tab registry, alongside bumping the cflib2 git revision to a commit that contains the required functionality.
Changes:
- Updated
cflib2git revision in project dependencies and lockfile. - Re-enabled
LEDRingTabin the UI tab loader. - Refactored
LEDRingTabto use asynccflib2param/memory APIs andcfclient.gui.create_task().
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
uv.lock |
Updates the locked cflib2 git revision. |
pyproject.toml |
Updates the direct dependency pin for cflib2 to the required commit. |
src/cfclient/ui/tabs/__init__.py |
Exposes LEDRingTab in the list of available tabs so it can be loaded. |
src/cfclient/ui/tabs/LEDRingTab.py |
Reworks the LED ring tab to use cflib2 async APIs and restores functionality. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gemenerik
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be merged after this cflib2 PR is merged.