Add wait_disconnect method to Crazyflie class for graceful disconnection#7
Merged
Add wait_disconnect method to Crazyflie class for graceful disconnection#7
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new async Python-exposed API on Crazyflie to allow callers to await a graceful/complete disconnect and retrieve a human-readable disconnect reason.
Changes:
- Add
Crazyflie.wait_disconnect()to the Rust PyO3 bindings, returning an awaitable that resolves to a string reason. - Update the generated Python type stub (
_rust.pyi) to include the new async method and its docstring.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rust/src/crazyflie.rs | Exposes a new wait_disconnect() async binding via future_into_py. |
| cflib2/_rust.pyi | Adds the wait_disconnect() declaration/documentation to the Python stubs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an async wait_disconnect() method that blocks until the Crazyflie disconnects, returning a human-readable reason string. Useful for graceful shutdown flows, e.g. waiting for link loss before cleaning up resources.