feat: add the ability to paste from gdrive links #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
FYI; I also fixed an issue where it failed to create the Google Sheet when it was contained within a Shared Drive. |
stevenle
reviewed
Jan 13, 2026
| const clientId = window.__ROOT_CTX.gapi!.clientId!; | ||
| const scopes = [...SCOPES, ...(options?.scopes || [])]; | ||
| // De-dupe scopes. | ||
| const uniqueScopes = [...new Set(scopes)]; |
Member
There was a problem hiding this comment.
I think I prefer to use Array.from(new Set(scopes)) instead of the spread operator. Probably better to do it in one line as well, e.g.
const scopes = Array.from(new Set([
...SCOPES,
...(options?.scopes || []),
]));
packages/root-cms/ui/utils/gdrive.ts
Outdated
| import {GapiClient} from '../hooks/useGapiClient.js'; | ||
|
|
||
| /** Extracts the Google Drive file ID from a URL. */ | ||
| export function getGoogleDriveId(url: string): string | null { |
Member
There was a problem hiding this comment.
The way this is implemented feels error prone since any URLs from google.com could potentially be pasted here and potentially return a Google Drive ID. I think this needs to be more deterministic and possibly create unit tests to verify.
stevenle
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to paste text (Google Drive URLs - e.g.
https://drive.google.com/open?id=1q4466dGkfhb9vKArGxopAkqB3QcjnjQn&usp=drive_copy) into the file field (when focused) in order to have Root CMS download the file from gDrive then upload it to the CMS.