fix: move nlean from standalone devnet to shared local-devnet#143
Open
fix: move nlean from standalone devnet to shared local-devnet#143
Conversation
nlean was incorrectly configured with its own separate local-devnet-nlean/ directory and genesis. It should participate in the shared local-devnet/genesis alongside all other clients. - Add nlean_0 to local-devnet/genesis/validator-config.yaml (quic: 9010, metrics: 8090, api: 5060) - Remove local-devnet-nlean/ standalone directory
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the nlean client from a standalone devnet into the shared local-devnet genesis so it can participate alongside the other interop clients.
Changes:
- Adds
nlean_0as a 10th validator inlocal-devnet/genesis/validator-config.yamlusing the next available QUIC / metrics / API ports. - Removes the now-redundant standalone nlean devnet validator config under
local-devnet-nlean/.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
local-devnet/genesis/validator-config.yaml |
Adds nlean_0 with ports continuing the existing allocation sequence (QUIC 9010, metrics 8090, API 5060). |
local-devnet-nlean/genesis/validator-config.yaml |
Deletes the standalone nlean validator config (previous 4-node setup). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nlean_0tolocal-devnet/genesis/validator-config.yaml(quic: 9010, metrics: 8090, api: 5060)local-devnet-nlean/directoryProblem
PR #137 created a separate
local-devnet-nlean/directory with its own genesis and 4 nlean-only nodes. This means nlean can't participate in the shared interop devnet (NETWORK_DIR=local-devnet) alongside other clients.Fix
Add nlean as the 10th validator in the shared
local-devnet/genesis/validator-config.yaml, following the same port allocation pattern as all other clients. Remove the now-unnecessarylocal-devnet-nlean/directory.Test plan
NETWORK_DIR=local-devnet ./spin-node.sh --node all --generateGenesisand verify nlean_0 joins alongside the other 9 clients