Skip to content

Conversation

@nicoschmdt
Copy link
Contributor

@nicoschmdt nicoschmdt commented Nov 13, 2025

fix #2019

Summary by Sourcery

Prevent users from initiating board changes or firmware installations when the vehicle is not in a safe state

Enhancements:

  • Disable “Change board” button in Autopilot view if the vehicle is armed
  • Block firmware installation actions in FirmwareManager when not safe

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 13, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduces a safety lock in the Autopilot UI by adding an is_safe computed state based on autopilot_data.is_safe, and updates both the board change button and firmware installation logic to be disabled when the vehicle is not in a safe state.

Class diagram for updated Autopilot and FirmwareManager components

classDiagram
  class Autopilot {
    +is_safe: boolean
    +restarting: boolean
    +openBoardChangeDialog()
    +fetch_available_boards_task
  }
  class FirmwareManager {
    +allow_installing(): boolean
    +install_status
  }
  Autopilot <.. FirmwareManager: uses autopilot_data.is_safe
  Autopilot : +is_safe() computed property
  FirmwareManager : +allow_installing() checks autopilot_data.is_safe
Loading

File-Level Changes

Change Details Files
Disable board change action when vehicle isn’t safe
  • Add is_safe computed property referencing autopilot_data.is_safe
  • Update Change board button :disabled binding to include !is_safe
core/frontend/src/views/Autopilot.vue
Prevent firmware installation when vehicle isn’t safe
  • Insert early if (!autopilot_data.is_safe) return false in allow_installing
  • Maintain existing install status checks after the safety guard
core/frontend/src/components/autopilot/FirmwareManager.vue

Assessment against linked issues

Issue Objective Addressed Explanation
#2019 Prevent firmware update when the vehicle is armed.
#2019 Disable the 'Change board' button when the vehicle is armed.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@patrickelectric patrickelectric merged commit c1be155 into bluerobotics:master Nov 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not allow firmware update when vehicle is armed

2 participants