Fix issues with rendering RDS inventory as a table + EKS support#7
Open
aminland wants to merge 2 commits into
Open
Fix issues with rendering RDS inventory as a table + EKS support#7aminland wants to merge 2 commits into
aminland wants to merge 2 commits into
Conversation
aminland
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the RDS inventory throws an error. It can't be rendered because the vpc_name and security_group fields are returning a list. Joining these into a single string seems to do the trick.
Additionally, it is much more useful for matching purposes to show the DB Identifier rather than the db name (DB Identifier is what is shown in RDS console).
Update:
This PR now also includes the ability to report on EKS clusters.