Move open3d to from pip to config dependency and remove duplicate pycolmap dependency #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushbaid
commented
Sep 10, 2024
| - pydegensac | ||
| - colour | ||
| - trimesh[easy] | ||
| - pycolmap>=0.1.0 |
Contributor
Author
There was a problem hiding this comment.
Pycolmap is already configured on line 51.
Comment on lines
+34
to
+35
| mamba env create -f environment_linux.yml | ||
| mamba activate gtsfm-v1 # you may need "source activate gtsfm-v1" depending upon your bash and conda set-up |
Collaborator
There was a problem hiding this comment.
Why are we changing to mamba?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing config failed for me because of open3d. Using the conda install worked better for me on my mac (M2 silicon)