Add some asserts for non parallelised XZ interpolation #3206
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| w3(localmesh) { | ||
|
|
||
| if (localmesh->getNXPE() > 1) { | ||
| throw BoutException("Do not support MPI splitting in X"); |
There was a problem hiding this comment.
warning: no header providing "BoutException" is directly included [misc-include-cleaner]
src/mesh/interpolation/bilinear_xz.cxx:22:
- #include "bout/globals.hxx"
+ #include "bout/boutexception.hxx"
+ #include "bout/globals.hxx"|
|
||
| XZHermiteSpline::XZHermiteSpline(int y_offset, Mesh* mesh) | ||
| : XZInterpolation(y_offset, mesh), h00_x(localmesh), h01_x(localmesh), | ||
| XZHermiteSpline::XZHermiteSpline(int y_offset, Mesh* meshin) |
There was a problem hiding this comment.
warning: constructor does not initialize these fields: petscWeights, rhs, result [cppcoreguidelines-pro-type-member-init]
include/bout/interpolation_xz.hxx:163:
- Mat petscWeights;
- Vec rhs, result;
+ Mat petscWeights{};
+ Vec rhs{}, result{};| : XZInterpolation(y_offset, mesh), t_x(localmesh), t_z(localmesh) { | ||
|
|
||
| if (localmesh->getNXPE() > 1) { | ||
| throw BoutException("Do not support MPI splitting in X"); |
There was a problem hiding this comment.
warning: no header providing "BoutException" is directly included [misc-include-cleaner]
src/mesh/interpolation/lagrange_4pt_xz.cxx:22:
- #include "bout/globals.hxx"
+ #include "bout/boutexception.hxx"
+ #include "bout/globals.hxx"
| ASSERT1(f.getMesh() == localmesh); | ||
| Field3D f_interp{emptyFrom(f)}; | ||
|
|
||
| const auto region2 = fmt::format("RGN_YPAR_{:+d}", y_offset); |
There was a problem hiding this comment.
warning: no header providing "fmt::format" is directly included [misc-include-cleaner]
src/mesh/interpolation/hermite_spline_xz.cxx:23:
- #include "bout/globals.hxx"
+ #include "fmt/format.h"
+ #include "bout/globals.hxx"
|
Failing in |
dschwoerer
force-pushed
the
add-assert-non-parallel
branch
from
2b82bc7 to
49028fe
Compare
|
|
| Field3D f_interp{emptyFrom(f)}; | ||
|
|
||
| const auto region2 = | ||
| y_offset == 0 ? "RGN_NOY" : fmt::format("RGN_YPAR_{:+d}", y_offset); |
There was a problem hiding this comment.
warning: no header providing "fmt::format" is directly included [misc-include-cleaner]
src/mesh/interpolation/hermite_spline_xz.cxx:23:
- #include "bout/globals.hxx"
+ #include "fmt/format.h"
+ #include "bout/globals.hxx"
dschwoerer
dismissed
ZedThree’s stale review
I have addressed the comments, should be good for re-review.
No description provided.