Skip to content

Handle special outputCollection defined variables#84

Open
nikku wants to merge 2 commits intomainfrom
unscopableOutputCollection
Open

Handle special outputCollection defined variables#84
nikku wants to merge 2 commits intomainfrom
unscopableOutputCollection

Conversation

@nikku
Copy link
Member

@nikku nikku commented Feb 25, 2026

Proposed Changes

Ensure that outputCollection is a variable that always bubbles - it cannot be contained in ad-hoc sub-processes.

Depends on bpmn-io/extract-process-variables#38

Checklist

Ensure you provide everything we need to review your contribution:

  • Contribution meets our definition of done
  • Pull request establishes context
    • Link to related issue(s), i.e. Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}
    • Brief textual description of the changes
    • Screenshots or short videos showing UI/UX changes
    • Steps to try out, i.e. using the @bpmn-io/sr tool

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 25, 2026
@nikku nikku changed the base branch from main to utils February 25, 2026 21:53
@nikku nikku force-pushed the unscopableOutputCollection branch from 552e446 to 105afe6 Compare February 25, 2026 21:56
@nikku nikku force-pushed the unscopableOutputCollection branch from 105afe6 to b519cab Compare February 25, 2026 22:05
@nikku nikku force-pushed the unscopableOutputCollection branch from b519cab to 2241c1b Compare February 25, 2026 22:43
Base automatically changed from utils to main February 26, 2026 21:30
@nikku nikku force-pushed the unscopableOutputCollection branch from 2241c1b to 9022253 Compare February 26, 2026 21:47
@nikku nikku marked this pull request as ready for review February 26, 2026 22:32
@nikku nikku requested review from a team, Buckwich, Copilot and ev-codes February 26, 2026 22:32
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 26, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates test expectations to reflect that outputCollection variables from ad-hoc sub-processes now always bubble up to the parent process scope and cannot be contained within the sub-process. This change depends on upstream modifications in @bpmn-io/extract-process-variables v2.2.0.

Changes:

  • Updated test assertions to expect toolCallResults (an outputCollection variable) to have parent process scope instead of ad-hoc sub-process scope
  • Modified test descriptions to clarify that outputCollection variables leak to parent processes
  • Added explanatory comments documenting that this leakage is intentional and cannot be prevented

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nikku nikku changed the title Unscopable output collection Handle special outputCollection defined variables Feb 26, 2026
@nikku nikku requested a review from barinali February 26, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Review pending

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants