Open
Conversation
552e446 to
105afe6
Compare
105afe6 to
b519cab
Compare
b519cab to
2241c1b
Compare
2241c1b to
9022253
Compare
There was a problem hiding this comment.
Pull request overview
This pull request updates test expectations to reflect that outputCollection variables from ad-hoc sub-processes now always bubble up to the parent process scope and cannot be contained within the sub-process. This change depends on upstream modifications in @bpmn-io/extract-process-variables v2.2.0.
Changes:
- Updated test assertions to expect
toolCallResults(an outputCollection variable) to have parent process scope instead of ad-hoc sub-process scope - Modified test descriptions to clarify that outputCollection variables leak to parent processes
- Added explanatory comments documenting that this leakage is intentional and cannot be prevented
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outputCollection defined variables
barinali
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Ensure that
outputCollectionis a variable that always bubbles - it cannot be contained in ad-hoc sub-processes.Depends on bpmn-io/extract-process-variables#38
Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool