Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -3,10 +3,12 @@ const { OpenAI } = require('openai'); | |||
| const core = require("@actions/core"); | |||
There was a problem hiding this comment.
What: The addition of 'instructions' as a parameter in the constructor is a change that should also have a validation check.
Why: Ensuring that all parameters passed to the constructor are validated can prevent runtime errors and ensure the integrity of the data.
How: Add validation logic to check if 'instructions' is either a string or undefined before assigning it to 'this.instructions'.
| @@ -285,14 +287,17 @@ class AiHelper { | |||
| for (const comments of prComments) { | |||
There was a problem hiding this comment.
What: The new comment formatting for review comments does not provide validation for the 'severity' and 'priority' fields.
Why: Lack of validation allows potential for unexpected data to be processed, which can lead to confusion or errors when the comment is generated.
How: Implement checks to ensure 'severity' and 'priority' are among the expected values (e.g., 'High', 'Medium', 'Low'). You can use a utility function like isValidSeverity(severity) to validate these.
1 participant
No description provided.