Skip to content

fix: clear manager cache on sync skip#1085

Draft
SmaGMan wants to merge 6 commits into
refactor/cancel-collationfrom
fix/clear-manager-cache-on-sync
Draft

fix: clear manager cache on sync skip#1085
SmaGMan wants to merge 6 commits into
refactor/cancel-collationfrom
fix/clear-manager-cache-on-sync

Conversation

@SmaGMan
Copy link
Copy Markdown
Member

@SmaGMan SmaGMan commented May 19, 2026

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[None] / [Yes]

BLOCKCHAIN CONFIGURATION MODEL CHANGES

[None] / [Yes]


COMPATIBILITY

Affected features:

  • [State]
  • [State. Blockchain Config]
  • [Block]
  • [Block Proof]
  • [Archive]
  • [Persistent State]
  • [Persistent Queue]
  • [Storage. Blocks]
  • [Storage. States]
  • [Storage. Archives]
  • [Queue. Diff]
  • [Queue. Storage]
  • [Queue. Storage. Statistics]
  • [Message Processing Algorithm]
  • [ProcessedUpto]
  • [Collator. Limits]
  • [Collator. Work Units Calculation]
  • [Mempool. Consensus Config]
  • [Mempool. Validation rules]
  • [Mempool. Storage]
  • [Mempool. API tl models]

SPECIAL DEPLOYMENT ACTIONS

[Not Required] / [Required]


PERFORMANCE IMPACT

[No impact expected] / [Expected impact]


TESTS

Unit Tests

[Covered by:] / [No coverage]

Network Tests

[Covered by:] / [No coverage]

Manual Tests

[Manual tests used]

  • [1-255]
  • [transfers]
  • [swaps]

Notes/Additional Comments:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1085

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1085
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1085 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@SmaGMan SmaGMan force-pushed the fix/clear-manager-cache-on-sync branch from 31fdaeb to a643b1c Compare May 19, 2026 10:22
@SmaGMan SmaGMan changed the base branch from master to refactor/cancel-collation May 19, 2026 10:22
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 78.78049% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.68%. Comparing base (356af0e) to head (a643b1c).

Files with missing lines Patch % Lines
collator/src/manager/msgs_queue.rs 76.60% 55 Missing and 7 partials ⚠️
collator/src/manager/sync.rs 77.77% 8 Missing and 8 partials ⚠️
collator/src/manager/blocks_cache.rs 87.67% 9 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           refactor/cancel-collation    #1085      +/-   ##
=============================================================
+ Coverage                      57.53%   57.68%   +0.14%     
=============================================================
  Files                            464      464              
  Lines                          77091    77432     +341     
  Branches                       77091    77432     +341     
=============================================================
+ Hits                           44353    44665     +312     
- Misses                         30720    30741      +21     
- Partials                        2018     2026       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant