-
Notifications
You must be signed in to change notification settings - Fork 1
[BC-26568] Add rubocop warning for the use of Bugsnag #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cf4f277
[BC-26568] Added rubocop warning for the use of Bugsnag
pramod-mahadev-bhat-1996 9b39efb
[BC-26568] Added rubocop warning for the use of Bugsnag
pramod-mahadev-bhat-1996 38a2f01
[BC-26568] Added rubocop warning for the use of Bugsnag
pramod-mahadev-bhat-1996 43c7f8d
Updated rspec
pramod-mahadev-bhat-1996 3303775
Updated rspec
pramod-mahadev-bhat-1996 55b6639
Updated rspec
pramod-mahadev-bhat-1996 585858a
Updated rspec
pramod-mahadev-bhat-1996 5dff8bc
Updating rspec
pramod-mahadev-bhat-1996 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| module RuboCop | ||
| module Cop | ||
| module Bugcrowd | ||
| class PreventBugsnagUsage < RuboCop::Cop::Base | ||
| MSG = 'Avoid using Bugsnag in the codebase. ' \ | ||
| 'It has been replaced with ErrorNotifierService for error ' \ | ||
| 'notification handling. Please use ErrorNotifierService instead.' | ||
pramod-mahadev-bhat-1996 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| def on_send(node) | ||
| add_offense(node, message: MSG) if node.receiver&.const_name == 'Bugsnag' | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| RSpec.describe RuboCop::Cop::Bugcrowd::PreventBugsnagUsage, :config do | ||
| subject(:cop) { described_class.new(config) } | ||
|
|
||
| let(:message) do | ||
| 'Avoid using Bugsnag in the codebase. ' \ | ||
| 'It has been replaced with ErrorNotifierService for error ' \ | ||
pramod-mahadev-bhat-1996 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| 'notification handling. Please use ErrorNotifierService instead.' | ||
| end | ||
|
|
||
| it 'registers an offense when Bugsnag is used' do | ||
| expect_offense(<<~RUBY) | ||
| Bugsnag.error('Error') | ||
| ^^^^^^^^^^^^^^^^^^^^^^ #{message} | ||
| RUBY | ||
| end | ||
|
|
||
| it 'registers an offense when Bugsnag.notify is used' do | ||
| expect_offense(<<~RUBY) | ||
| Bugsnag.notify('Error') | ||
| ^^^^^^^^^^^^^^^^^^^^^^^ #{message} | ||
| RUBY | ||
| end | ||
|
|
||
| it 'does not register an offense for ErrorNotifierService' do | ||
| expect_no_offenses(<<~RUBY) | ||
| ErrorNotifierService.notify('Error') | ||
| RUBY | ||
| end | ||
|
|
||
| it 'does not register an offense for unrelated constants' do | ||
| expect_no_offenses(<<~RUBY) | ||
| SomeOtherService.notify('Error') | ||
| RUBY | ||
| end | ||
|
|
||
| it 'does not register an offense for lowercase bugsnag' do | ||
| expect_no_offenses(<<~RUBY) | ||
| bugsnag.error('Error') | ||
| RUBY | ||
| end | ||
|
|
||
| it 'does not register an offense for local variable named Bugsnag' do | ||
| expect_no_offenses(<<~RUBY) | ||
| bugsnag = SomeService.new | ||
| bugsnag.error('Error') | ||
| RUBY | ||
| end | ||
| end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.