Ensure onSpanEnd callbacks are always invoked for ended spans #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Android notifier sizes
Android notifier size impact
Generated by 🚫 Danger |
yousif-bugsnag
force-pushed
the
run-callbacks-for-sampled-spans
branch
from
2e6a8b7 to
3d4b46f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes an issue where onSpanEnd callbacks are not invoked for sampled spans. Since the span tracking plugins rely on these callbacks to stop tracking spans, it means they end up holding on to span references for longer than is necessary.
Design
Reversed the logic in the Tracer's
onEndmethod so that the callbacks are invoked before the sampling checkTesting
Covered by CI