Skip to content

Commit b848220

Browse files
twometrestevetwometresteve
authored
Merge pull request #534 from bugsnag/tms/remove-steps-3
Remove redundant scenario steps (part 3)
2 parents 0a3c396 + 9ef8568 commit b848220

16 files changed

+0
-200
lines changed

‎features/default/automatic/automatic_app_start.feature‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ Feature: Automatic app start instrumentation spans
88
And I wait to receive a span named "[AppStartPhase/App launching - post main()]"
99
And I wait to receive a span named "[AppStartPhase/UI init]"
1010
Then the trace "Content-Type" header equals "application/json"
11-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
12-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
1311
* every span field "kind" equals 1
1412
* a span string attribute "bugsnag.app_start.type" equals "cold"
1513
* a span string attribute "bugsnag.phase" equals "App launching - pre main()"
@@ -49,8 +47,6 @@ Feature: Automatic app start instrumentation spans
4947
And I wait to receive a span named "[ViewLoadPhase/Subview layout]/Fixture.ViewController"
5048
And I wait to receive a span named "[ViewLoadPhase/viewDidLayoutSubviews]/Fixture.ViewController"
5149
Then the trace "Content-Type" header equals "application/json"
52-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
53-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
5450
* every span field "kind" equals 1
5551
* a span string attribute "bugsnag.app_start.type" equals "cold"
5652
* a span string attribute "bugsnag.phase" equals "App launching - pre main()"
@@ -102,8 +98,6 @@ Feature: Automatic app start instrumentation spans
10298
And I wait to receive a span named "[ViewLoadPhase/viewDidLayoutSubviews]/Fixture.AutoInstrumentAppStartsLoadingScenario_ViewController"
10399
And I wait to receive a span named "[ViewLoadPhase/viewDataLoading]/Fixture.AutoInstrumentAppStartsLoadingScenario_ViewController"
104100
Then the trace "Content-Type" header equals "application/json"
105-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
106-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
107101
* every span field "kind" equals 1
108102
* a span string attribute "bugsnag.app_start.type" equals "cold"
109103
* a span string attribute "bugsnag.phase" equals "App launching - pre main()"

‎features/default/automatic/automatic_network.feature‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ Feature: Automatic network instrumentation spans
1515
* a span integer attribute "http.status_code" is greater than 0
1616
* a span integer attribute "http.response_content_length" is greater than 0
1717
* a span string attribute "net.host.connection.type" equals "wifi"
18-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
19-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
2018
* a span field "kind" equals 1
2119
* a span field "kind" equals 3
2220
* a span bool attribute "bugsnag.span.first_class" is true
@@ -38,8 +36,6 @@ Feature: Automatic network instrumentation spans
3836
* a span integer attribute "http.status_code" is greater than 0
3937
* a span integer attribute "http.response_content_length" is greater than 0
4038
* a span string attribute "net.host.connection.type" equals "wifi"
41-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
42-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
4339
* a span field "kind" equals 1
4440
* a span field "kind" equals 3
4541
* a span bool attribute "bugsnag.span.first_class" is true
@@ -59,8 +55,6 @@ Feature: Automatic network instrumentation spans
5955
* a span integer attribute "http.status_code" is greater than 0
6056
* a span integer attribute "http.response_content_length" is greater than 0
6157
* a span string attribute "net.host.connection.type" equals "wifi"
62-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
63-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
6458
* every span field "kind" equals 3
6559
* the trace payload field "resourceSpans.0.resource" string attribute "service.name" matches the regex "com.bugsnag.fixtures.cocoaperformance(xcframework)?"
6660
* the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.name" equals "bugsnag.performance.cocoa"
@@ -87,8 +81,6 @@ Feature: Automatic network instrumentation spans
8781
* a span integer attribute "http.status_code" is greater than 0
8882
* a span integer attribute "http.response_content_length" is greater than 0
8983
* a span string attribute "net.host.connection.type" equals "wifi"
90-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
91-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
9284
* every span field "kind" equals 3
9385
* the trace payload field "resourceSpans.0.resource" string attribute "service.name" matches the regex "com.bugsnag.fixtures.cocoaperformance(xcframework)?"
9486
* the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.name" equals "bugsnag.performance.cocoa"
@@ -101,8 +93,6 @@ Feature: Automatic network instrumentation spans
10193
Then the trace "Content-Type" header equals "application/json"
10294
* every span field "parentSpanId" does not exist
10395
* a span field "name" equals "[HTTP/GET]"
104-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
105-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
10696
* a span field "kind" equals 1
10797
* a span field "kind" equals 3
10898
* a span string attribute "bugsnag.instrumentation_message" exists
@@ -128,8 +118,6 @@ Feature: Automatic network instrumentation spans
128118
* a span integer attribute "http.status_code" is greater than 0
129119
* a span integer attribute "http.response_content_length" is greater than 0
130120
* a span string attribute "net.host.connection.type" equals "wifi"
131-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
132-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
133121
* every span field "kind" equals 3
134122
* the trace payload field "resourceSpans.0.resource" string attribute "service.name" matches the regex "com.bugsnag.fixtures.cocoaperformance(xcframework)?"
135123
* the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.name" equals "bugsnag.performance.cocoa"
@@ -147,8 +135,6 @@ Feature: Automatic network instrumentation spans
147135
* a span integer attribute "http.status_code" is greater than 0
148136
* a span integer attribute "http.response_content_length" is greater than 0
149137
* a span string attribute "net.host.connection.type" equals "wifi"
150-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
151-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
152138
* every span field "kind" equals 3
153139
* the trace payload field "resourceSpans.0.resource" string attribute "service.name" matches the regex "com.bugsnag.fixtures.cocoaperformance(xcframework)?"
154140
* the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.name" equals "bugsnag.performance.cocoa"
@@ -163,8 +149,6 @@ Feature: Automatic network instrumentation spans
163149
And I wait to receive 2 spans
164150
Then the trace "Content-Type" header equals "application/json"
165151
* every span field "name" equals "[HTTP/GET]"
166-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
167-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
168152
* every span field "kind" equals 3
169153
* a span string attribute "http.url" equals "https://bugsnag.com"
170154
* a span string attribute "http.url" equals "https://bugsnag.com/changed"
@@ -177,8 +161,6 @@ Feature: Automatic network instrumentation spans
177161
And I wait to receive at least 1 span
178162
Then the trace "Content-Type" header equals "application/json"
179163
* a span field "name" equals "[HTTP/GET]"
180-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
181-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
182164
* every span field "kind" equals 3
183165
* a span string attribute "http.url" equals "https://bugsnag.com"
184166

‎features/default/automatic/automatic_spans_generic_view_load.feature‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ Feature: Automatic instrumentation spans AutoInstrumentGenericViewLoadScenario
2323
* a span field "name" equals "[ViewLoadPhase/viewWillLayoutSubviews]/Fixture.AutoInstrumentGenericViewLoadScenario_ViewController<Fixture.AutoInstrumentGenericViewLoadScenario_GenericsClass>"
2424
* a span field "name" equals "[ViewLoadPhase/Subview layout]/Fixture.AutoInstrumentGenericViewLoadScenario_ViewController<Fixture.AutoInstrumentGenericViewLoadScenario_GenericsClass>"
2525
* a span field "name" equals "[ViewLoadPhase/viewDidLayoutSubviews]/Fixture.AutoInstrumentGenericViewLoadScenario_ViewController<Fixture.AutoInstrumentGenericViewLoadScenario_GenericsClass>"
26-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
27-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
2826
* every span field "kind" equals 1
2927
* a span string attribute "bugsnag.span.category" equals "view_load"
3028
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewController"
@@ -57,8 +55,6 @@ Feature: Automatic instrumentation spans AutoInstrumentGenericViewLoadScenario
5755
* a span field "name" equals "[ViewLoadPhase/viewWillLayoutSubviews]/Fixture.GenericViewController<Swift.Int>"
5856
* a span field "name" equals "[ViewLoadPhase/Subview layout]/Fixture.GenericViewController<Swift.Int>"
5957
* a span field "name" equals "[ViewLoadPhase/viewDidLayoutSubviews]/Fixture.GenericViewController<Swift.Int>"
60-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
61-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
6258
* every span field "kind" equals 1
6359
* a span string attribute "bugsnag.span.category" equals "view_load"
6460
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewController"

‎features/default/automatic/automatic_swift_ui.feature‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ Feature: Automatic swift UI spans
88
* a span field "name" equals "[ViewLoadPhase/body]/My VStack view"
99
* a span field "name" equals "[ViewLoadPhase/body]/My Image view"
1010
# ios < 15 won't have the "view appearing" span
11-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
12-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
1311
* every span field "kind" equals 1
1412
* a span string attribute "bugsnag.span.category" equals "view_load"
1513
* a span string attribute "bugsnag.span.category" equals "view_load_phase"
@@ -28,8 +26,6 @@ Feature: Automatic swift UI spans
2826
* a span field "name" equals "[ViewLoad/SwiftUI]/My VStack view"
2927
* a span field "name" equals "[ViewLoadPhase/body]/My VStack view"
3028
* a span field "name" equals "[ViewLoadPhase/body]/My Image view"
31-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
32-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
3329
* every span field "kind" equals 1
3430
* a span string attribute "bugsnag.span.category" equals "view_load"
3531
* a span string attribute "bugsnag.span.category" equals "view_load_phase"
@@ -45,8 +41,6 @@ Feature: Automatic swift UI spans
4541
Then I wait to receive at least 2 spans
4642
* a span field "name" equals "[ViewLoad/SwiftUI]/Text"
4743
* a span field "name" equals "[ViewLoadPhase/body]/Text"
48-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
49-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
5044
* every span field "kind" equals 1
5145
* a span string attribute "bugsnag.span.category" equals "view_load"
5246
* a span string attribute "bugsnag.span.category" equals "view_load_phase"
@@ -60,8 +54,6 @@ Feature: Automatic swift UI spans
6054
Then the trace "Content-Type" header equals "application/json"
6155
* a span field "name" equals "[ViewLoadPhase/body]/vstack1"
6256
* a span field "name" equals "[ViewLoadPhase/body]/text1"
63-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
64-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
6557
* every span field "kind" equals 1
6658
* every span string attribute "bugsnag.span.category" equals "view_load_phase"
6759
* a span string attribute "bugsnag.view.name" equals "vstack1"
@@ -74,8 +66,6 @@ Feature: Automatic swift UI spans
7466
And I wait to receive at least 2 spans
7567
* a span field "name" equals "[ViewLoadPhase/body]/vstack1"
7668
* a span field "name" equals "[ViewLoadPhase/body]/text1"
77-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
78-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
7969
* every span field "kind" equals 1
8070
* every span string attribute "bugsnag.span.category" equals "view_load_phase"
8171
* a span string attribute "bugsnag.view.name" equals "vstack1"
@@ -87,8 +77,6 @@ Feature: Automatic swift UI spans
8777
Then the trace "Content-Type" header equals "application/json"
8878
* a span field "name" equals "[ViewLoadPhase/body]/vstack1"
8979
* a span field "name" equals "[ViewLoadPhase/body]/text1"
90-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
91-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
9280
* every span field "kind" equals 1
9381
* every span string attribute "bugsnag.span.category" equals "view_load_phase"
9482
* a span string attribute "bugsnag.view.name" equals "vstack1"
@@ -101,8 +89,6 @@ Feature: Automatic swift UI spans
10189
And I wait to receive at least 2 spans
10290
* a span field "name" equals "[ViewLoadPhase/body]/vstack1"
10391
* a span field "name" equals "[ViewLoadPhase/body]/text1"
104-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
105-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
10692
* every span field "kind" equals 1
10793
* every span string attribute "bugsnag.span.category" equals "view_load_phase"
10894
* a span string attribute "bugsnag.view.name" equals "vstack1"
@@ -112,8 +98,6 @@ Feature: Automatic swift UI spans
11298
And I wait to receive at least 2 spans
11399
* a span field "name" equals "[ViewLoad/SwiftUI]/vstack1"
114100
* a span field "name" equals "[ViewLoadPhase/body]/vstack1"
115-
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
116-
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
117101
* every span field "kind" equals 1
118102
* a span string attribute "bugsnag.span.category" equals "view_load"
119103
* a span string attribute "bugsnag.span.category" equals "view_load_phase"

0 commit comments

Comments
 (0)