PS-1695: configurable controller-id to via CLI and env var#828
Merged
Conversation
zhming0
force-pushed
the
ming/ps-1695
branch
from
9a749fc to
8514de4
Compare
DrJosh9000
reviewed
Feb 25, 2026
Contributor
There was a problem hiding this comment.
The name ID for an env var is non-specific (ID of what?), and if the controller weren't running in a container out in k8s there's a chance that ID might already exist (same goes for IMAGE, NAMESPACE, CONFIG). What about BUILDKITE_K8S_STACK_CONTROLLER_ID ?
Contributor
Author
|
@DrJosh9000 good idea. We probably can't break backward compatibility for other env var but we can make this new env var right. |
DrJosh9000
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the ID config for k8s stack configurable via CLI and Env var. Previously it was only configurable via config file.
It's a useful configuration for people who wants to deploy multiple controllers replicas for the same queue without using Helm.
As part of this change, I've documented the implication of ID in our job distribution.