Merged
Conversation
DrJosh9000
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #3697, we introduced a new feature to the agent to stream ping messages from the buildkite backend, rather than polling. For long-running agents, this should greatly decrease the amount of time between a job being assigned and the agent picking it up.
In this PR, we added a config item called
--ping-mode, which allows users to pick which ping mode they want to use, and defaulted it toauto. Whenping-modeisauto, the agent will attempt to use streaming pings, but if they're unavailable, it will fall back to polling.Unfortunately, because this feature is still under construction on the backend, at the time of writing, all attempts to connect to a ping stream will fail, outputting some error logs into the agent logs:
Because of the semantics of
--ping-mode auto, the agent immediately falls back to using the ping handler, so there's very little actual impact from this issue. It does look like a problem though, so this PR sets the default--ping-modetoping-onlyfor now. In a future release, we'll set the default back toauto.Context
Slack convo
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
n/a