Convenience method for multipart/form-data requests#258
Open
dondi wants to merge 3 commits intobustoutsolutions:mainfrom
Open
Convenience method for multipart/form-data requests#258dondi wants to merge 3 commits intobustoutsolutions:mainfrom
dondi wants to merge 3 commits intobustoutsolutions:mainfrom
Conversation
Member
|
Thanks for this PR, dondi, and sorry for letting it languish! I love the idea. I’ll give it a design review for the next minor release of Siesta. |
Author
|
No worries @pcantrell! I know how it goes 🙂 Glad you like the idea and I’ll just monitor the PR as things develop. |
|
Hello! Any chance to see it merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is motivated by and based on #190
Hope you don’t mind the warts and all (particularly the missing unit tests) @pcantrell —I’m very much a newbie in iOS dev, but I tried to not let that discourage me and sort of took your invitation from that issue thread at its word 😬
This same code is currently quite functional in an iOS app I’m working on that uploads files to an Amazon S3 bucket by way of a signed S3 URL. A sample call looks like this:
Shoutout and thanks to @Alex293 whose code in the issue thread is still pretty much what this convenience method is.
I’m happy to start the conversation of getting this convenience helper in to Siesta. Thanks!