Ensure --addr-pool mask accepts numbers only #4619
Merged
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linear0211
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
lum1n0us
reviewed
Sep 11, 2025
lum1n0us
added
the
bug-fix
lum1n0us
previously approved these changes
Oct 12, 2025
Contributor
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
LGTM. With minor comments
Co-authored-by: liang.he <[email protected]>
linear0211
force-pushed
the
main
branch
2 times, most recently
from
9237915 to
ed45cce
Compare
yamt
approved these changes
Dec 8, 2025
| #else | ||
| address = strtok_r(cp, "/", &nextptr); | ||
| mask = strtok_r(NULL, "/", &nextptr); | ||
| #endif |
Contributor
There was a problem hiding this comment.
maybe we can have bh_strtok_r function for this?
Contributor
There was a problem hiding this comment.
Agreed. However, I think we should use a new PR to implement that and merge it first. Does that sound good to you?
Contributor
Author
There was a problem hiding this comment.
Sounds good to me. Should I open a new PR for the implementation?
lum1n0us
approved these changes
Dec 8, 2025
| #else | ||
| address = strtok_r(cp, "/", &nextptr); | ||
| mask = strtok_r(NULL, "/", &nextptr); | ||
| #endif |
Contributor
There was a problem hiding this comment.
Agreed. However, I think we should use a new PR to implement that and merge it first. Does that sound good to you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--addr-pooloption previously usedatoito parse the mask value.If non-numeric characters were included,
atoireturned0, causing the pool to unintentionally accept all IP addresses.This change ensures the mask accepts only numeric values, preventing unexpected behavior.