Update pom.xml#5
Open
divinepwner wants to merge 1 commit intoc0ny1:masterfrom
divinepwner:patch-1
Open
Conversation
I updated pom.xml file to let users properly build it with latest version of Java and mvn. Without this update, OSX user couldn't buildl package properly. Its the best and easy solution for the error.
Owner
|
我的macOS下编译没有问题。我看到你在pom.xml指定了jdk的版本，删除编码设置。请问你有没有尝试过不删UTF-8编码的情况下，指定编译的jdk版本（1.6）是否可以成功编译？ I have no problem compiling on macOS. I saw that you specified the JDK version in pom.xml, removing the encoding Settings. Have you ever tried to specify the compiled JDK version (1.6) without deleting utf-8 encoding? |
Author
|
Yup. I tried but same. Failed. I find out that solution and it worked like a charm. So i want to send a pull request. May be its about our OS X versions. I am using 10.14.6 Mojave. |
Owner
|
Mine was version 10.14.5, and then I tried to update the test to see why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated pom.xml file to let users properly build it with latest version of Java and mvn. Without this update, OSX user couldn't buildl package properly. Its the best and easy solution for the error.