Remove naive check for SQL SELECT query #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are select queries that start with WITH statement (CTE) and many more. We have to limit the db user to select queries on the database and the system database (to explore tables and their columns) instead.
Member
|
Created a new user for this, but couldn't enable system selects for some reason. Prolly better to not enable that. See also this ticket: #5 |
Member
|
Prolly good to implement this permission checking as part of this PR: #4 |
Contributor
Author
|
@inodb good points. Let's this change for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are select queries that start with WITH statement (CTE) and many more.
We have to limit the db user to select queries on the database and the system database (to explore tables and their columns) instead.