Add nanoserver build to workflow and fix hardcoded dist_commit #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add nanoserver variants to GitHub Actions workflow - Replace hardcoded dist_commit with template variable in Dockerfile.nanoserver.tmpl
Member
|
Ah, thanks 👍 We won't update the library file until we're ready - it should reference the commit hash of the last significant change, which has to be a separate commit after that commit, obviously. |
Contributor
Author
|
Sounds good 👍 |
Member
|
We can still update the workflows tho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds Windows Nano Server container builds to the GitHub Actions workflow and fixes a bug in the Nano Server Dockerfile template.
What's Changed
Added nanoserver builds to workflow: Extended the GitHub Actions workflow to build and publish Nano Server container variants alongside the existing Server Core builds.
Fixed hardcoded dist_commit: Replaced the hardcoded
dist_commitvalue inDockerfile.nanoserver.tmplwith the template variable{{ .config.dist_commit }}. This ensures the dist_commit stays consistent with other Windows variants and updates automatically when the version changes.Why
The hardcoded dist_commit was a bug that would cause the Nano Server images to reference an outdated or incorrect commit hash, while other variants would use the correct templated value.
Testing
cc @francislavoie