fix: bottom navigation shifting={false} active pill display #4821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the bottom nav has the attribute shifting={false} the pill shape is
misformed on the active tabs. On clicking around this seems
inconsistent. (See callstack#4819)
This appears to be because the animated view is added / removed as the
tab is focused causing the animation to not play or half play. Since it
starts at 0.5 scaleX this appears to the user as a squashed pill shape.
The intended animation is to expand out from the center.
This commit fixes this by ensuring the animation is always present and
simply varies the outputRange of the animation depending on the focused
state.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| const outlineScale = active.interpolate({ | ||
| inputRange: [0, 1], | ||
| outputRange: focused ? [0.5, 1] : [0, 0], | ||
| }); |
There was a problem hiding this comment.
Bug: Tab Outline Fades Abruptly on Unfocus
The outline for a previously focused tab disappears abruptly instead of animating out smoothly. When focused becomes false, the outlineScale's outputRange immediately switches to [0, 0], causing an instant disappearance even while the active animation value is still transitioning.
|
Hey @studioromeo, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the bottom nav has the attribute shifting={false} the pill shape is misformed on the active tabs. On clicking around this seems inconsistent.
This appears to be because the animated view is added / removed as the tab is focused causing the animation to not play or half play. Since it starts at 0.5 scaleX this appears to the user as a squashed pill shape. The intended animation is to expand out from the center.
This commit fixes this by ensuring the animation is always present and simply varies the outputRange of the animation depending on the focused state.
Related issue
#4819
Test plan
Note: I had failures running the tests on
mainwhich i could not resolve so I've had to skip running the tests for this PR however I have run the other yarn checks. Apologies for this and I would appreciate if anyone could run the tests on this.