feat: Add initial CronJob as external reconciler for resource cleanup#22
Draft
lbeckman314 wants to merge 1 commit into
Draft
feat: Add initial CronJob as external reconciler for resource cleanup#22lbeckman314 wants to merge 1 commit into
lbeckman314 wants to merge 1 commit into
Conversation
Signed-off-by: Liam Beckman <lbeckman314@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview 🌀
This PR adds an initial cronjob to act as an for resource cleanup in K8s (i.e. "external reconciler")
It runs an example command (
funnel kubernetes cleanup) that is designed to call the update "modular reconciler" implemented in uc-cdis:funnel:chore/reconcile_modularTip
calypr/funnel@develop...uc-cdis:funnel:chore/reconcile_modular
Current Behavior⚠️
K8s resource cleanup is run in the resource-intensive (and complicated!) functions directly in Funnel:
(kubernetes.Backend).reconcile(kubernetes.Backend).CleanOrphanedResourcesNew Behavior ✔️
Resources are cleaned in a single, user-configurable Helm template.
Caution
TODO: Add examples of defaults + configuration options, for example:
Backwards Compatibilty 🔄
Caution
TODO: Does this new behavior affect existing workflows/setups?