[14.0] stock_average_daily_sale: returns handling #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
force-pushed
the
14.0-stock_average_daily_sale-returns_handling
branch
3 times, most recently
from
8c90cfc to
b088b33
Compare
sebalix
force-pushed
the
14.0-stock_average_daily_sale-returns_handling
branch
from
b088b33 to
7bb974d
Compare
twalter-c2c
force-pushed
the
14.0-stock_average_daily_sale-returns_handling
branch
3 times, most recently
from
f3e6849 to
1c7220a
Compare
henrybackman
reviewed
Dec 9, 2024
sebalix
commented
Dec 9, 2024
Member
Author
sebalix
left a comment
sebalix
left a comment
There was a problem hiding this comment.
@twalter-c2c the new help should be done through a field override in customer specific modules (I guess they have been updated in that regards, not to be proposed to OCA?).
twalter-c2c
force-pushed
the
14.0-stock_average_daily_sale-returns_handling
branch
from
1c7220a to
03abbfa
Compare
henrybackman
requested changes
Dec 10, 2024
twalter-c2c
force-pushed
the
14.0-stock_average_daily_sale-returns_handling
branch
3 times, most recently
from
99e272d to
86935c1
Compare
twalter-c2c
changed the base branch from
14.0-mig-stock_average_daily_sale
to
14.0
Currently translated at 100.0% (59 of 59 strings) Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-stock_average_daily_sale Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-stock_average_daily_sale/it/
Currently translated at 16.6% (1 of 6 strings) Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-stock_picking_report_custom_description Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-stock_picking_report_custom_description/it/
Currently translated at 25.0% (1 of 4 strings) Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-stock_account_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-stock_account_quantity_history_location/it/
Currently translated at 16.6% (1 of 6 strings) Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-stock_quant_history_queued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-stock_quant_history_queued/it/
Currently translated at 14.2% (1 of 7 strings) Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-delivery_line_sale_line_position Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-delivery_line_sale_line_position/it/
Currently translated at 25.0% (1 of 4 strings) Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-stock_picking_group_by_partner_by_carrier_sale_line_position Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-stock_picking_group_by_partner_by_carrier_sale_line_position/it/
jbaudoux
requested changes
Mar 17, 2025
Member
jbaudoux
left a comment
jbaudoux
left a comment
There was a problem hiding this comment.
Why hiding such change?
You would have opened a PR on OCA, you would maybe had reviews.
| ) as recommended_qty | ||
| ) as recommended_qty, | ||
| GREATEST( | ||
| (cfg.number_days_qty_in_stock * (average_qty_by_sale - COALESCE(average_qty_by_return, 0)) * (average_daily_sales_count - COALESCE(average_daily_returns_count, 0))) + ((ds.daily_standard_deviation - COALESCE(dsr.daily_standard_deviation, 0)) * cfg.safety_factor * sqrt(nbr_days)), |
Member
There was a problem hiding this comment.
This new formula looks wrong to me
If you always ship 10 and you return also 10, then average_qty_by_sale - average_qty_by_return = 0. So a single return will put the recommended qty to 0. That's wrong.
You need to compute the daily sale - the daily return
Suggested change
| (cfg.number_days_qty_in_stock * (average_qty_by_sale - COALESCE(average_qty_by_return, 0)) * (average_daily_sales_count - COALESCE(average_daily_returns_count, 0))) + ((ds.daily_standard_deviation - COALESCE(dsr.daily_standard_deviation, 0)) * cfg.safety_factor * sqrt(nbr_days)), | |
| (cfg.number_days_qty_in_stock * ( | |
| average_qty_by_sale * average_daily_sales_count | |
| - COALESCE(average_qty_by_return, 0) * COALESCE(average_daily_returns_count, 0) | |
| ) + ((ds.daily_standard_deviation - COALESCE(dsr.daily_standard_deviation, 0)) * cfg.safety_factor * sqrt(nbr_days)), |
There was a problem hiding this comment.
@sebalix is the author of these changes, but I also know the topic so I will clarify.
We have 'hidden' the returns handling because the way we handle returns is not universal here. In this case, as returns, we consider moves where sl_src.usage in ('inventory') AND sl_dest.usage in ('internal') which is rather a custom requirement.
The changes you requested are still relevant in my opinion though. Thank you for the suggestion, I will fix that.
Member
There was a problem hiding this comment.
Thanks @twalter-c2c
I'm still clarifying the formula with Meredith
twalter-c2c
force-pushed
the
14.0-stock_average_daily_sale-returns_handling
branch
from
9eea93a to
5d42c8d
Compare
Take returns into account while calculating average daily sale usage. In our specific case, returns mean stock moves from the 'Inventory adjustment' location to the physical stock location (of usage 'internal'). Co-Authored-By: Sébastien Alix <[email protected]>
twalter-c2c
force-pushed
the
14.0-stock_average_daily_sale-returns_handling
branch
from
5d42c8d to
3c309ed
Compare
twalter-c2c
force-pushed
the
14.0-stock_average_daily_sale-returns_handling
branch
from
3c309ed to
14507cf
Compare
florentx
approved these changes
Mar 26, 2025
florentx
left a comment
florentx
left a comment
There was a problem hiding this comment.
LG, but I did not dig into algorithm itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready to be proposed on OCA, so this PR was open to ease internal reviews.
Based on: